Skip to content

Change profilers to use thread local evacuation counters #59741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkotas merged 7 commits into from
Oct 7, 2021
Merged

Change profilers to use thread local evacuation counters #59741

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1a0fea7
Change profilers to use thread local evacuation counters
davmason Sep 28, 2021
c30e4cc
get rid of lambdas
davmason Oct 2, 2021
c46a4df
Fix jit inlining, fix R2R too
davmason Oct 6, 2021
e8e39fd
Remove VolatilePtr<> from helpers
davmason Oct 6, 2021
cb927c3
Replace static contracts that I accidentally overwrote
davmason Oct 6, 2021
126bd62
Get rid of additionalData argument
davmason Oct 6, 2021
e9b9cc2
Initialize params for every call
davmason Oct 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix jit inlining, fix R2R too
  • Loading branch information
@davmason
davmason committed Oct 6, 2021
commit c46a4df1ad64f7df2da462ac5f3a99d6a1f64916
6 changes: 4 additions & 2 deletions src/coreclr/inc/profilepriv.inl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,14 +527,15 @@ inline BOOL IsProfilerTrackingCacheSearches(ProfilerInfo *pProfilerInfo)
inline HRESULT JITCachedFunctionSearchStartedHelper(BOOL *pAllTrue, VolatilePtr<EEToProfInterfaceImpl> profInterface, FunctionID functionId, BOOL *pbUseCachedFunction)
{
HRESULT hr = profInterface->JITCachedFunctionSearchStarted(functionId, pbUseCachedFunction);
*pAllTrue &= *pbUseCachedFunction;
*pAllTrue = *pAllTrue && *pbUseCachedFunction;
return hr;
}

inline void ProfControlBlock::JITCachedFunctionSearchStarted(FunctionID functionId, BOOL *pbUseCachedFunction)
{
LIMITED_METHOD_CONTRACT;

*pbUseCachedFunction = TRUE;
BOOL allTrue = TRUE;
DoProfilerCallback(ProfilerCallbackType::Active,
IsProfilerTrackingCacheSearches,
Expand Down Expand Up @@ -565,14 +566,15 @@ inline void ProfControlBlock::JITCachedFunctionSearchFinished(FunctionID functio
inline HRESULT JITInliningHelper(BOOL *pAllTrue, VolatilePtr<EEToProfInterfaceImpl> profInterface, FunctionID callerId, FunctionID calleeId, BOOL *pfShouldInline)
{
HRESULT hr = profInterface->JITInlining(callerId, calleeId, pfShouldInline);
*pAllTrue &= *pfShouldInline;
*pAllTrue = *pAllTrue && *pfShouldInline;
return hr;
}

inline HRESULT ProfControlBlock::JITInlining(FunctionID callerId, FunctionID calleeId, BOOL *pfShouldInline)
{
LIMITED_METHOD_CONTRACT;

*pfShouldInline = TRUE;
Copy link
Member

@jkotas jkotas Oct 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will initialize *pfShouldInline deterministically for the first profiler only.

Should this line rather be in JITInliningHelper instead? I think you can even delete pfShouldInline argument for the JITInliningHelper and have BOOL fShouldInline local in JITInliningHelper instead.

BOOL allTrue = TRUE;
HRESULT hr = DoProfilerCallback(ProfilerCallbackType::Active,
IsProfilerTrackingJITInfo,
Expand Down