Skip to content

Retry installer Process.Start if ETXTBSY #59765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
agocke merged 3 commits into from
Sep 29, 2021
Merged

Retry installer Process.Start if ETXTBSY #59765

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
866aaeb
Retry installer Process.Start if ETXTBSY
agocke Sep 29, 2021
bdc3759
Add comment
agocke Sep 29, 2021
acc8879
Address PR comments
agocke Sep 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Address PR comments
  • Loading branch information
@agocke
agocke committed Sep 29, 2021
commit acc887934384eb4ad68d93b2e2c8d78a1d29fcd5
4 changes: 2 additions & 2 deletions src/installer/tests/TestUtils/Command.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,14 +199,14 @@ public Command Start()

// Retry if we hit ETXTBSY due to Linux race
// https://github.com/dotnet/runtime/issues/58964
for (int i = 0; i < 3; i++)
for (int i = 0; ; i++)
{
try
{
Process.Start();
break;
}
catch (Win32Exception e) when (e.Message.Contains("Text file busy"))
catch (Win32Exception e) when (i < 3 && e.Message.Contains("Text file busy"))
{
// 10 ms is short, but the race we're trying to avoid is in-between
// "fork" and "exec", so it should be fast
Copy link
Member

@VSadov VSadov Sep 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to balance latency and likelihood of waiting long enough, perhaps we should scale the backoff a little, like this could be Sleep(i * 10) ?

Copy link
Member Author

@agocke agocke Sep 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably worth seeing if this solves the issue, but there's no reason we can't come back to it later.

Expand Down