Update Regex source generator to use new GetBestTypeByMetadataName method

[stephentoub]

cc: @steveharter

[ghost]

Tagging subscribers to this area: @eerhardt, @dotnet/area-system-text-regularexpressions
See info in area-owners.md if you want to be subscribed.

Issue Details

---

cc: @steveharter

Author:	stephentoub
Assignees:	-
Labels:	area-System.Text.RegularExpressions
Milestone:	-

[danmoseley]

can we add a test/ extend an existing test?

[stephentoub]

can we add a test/ extend an existing test?

I added one.

[eerhardt]

[stephentoub]

@lewing, the Browser wasm AOT leg here is deterministically timing out / getting killed while compiling this test assembly. What should I do?

  ** Building a proxy for the original test project, to AOT on helix. In order to do that, this recreates the original inputs for the *wasm* part of the build. See /datadisks/disk1/work/A8C00962/w/AD6509B4/e/publish/ProxyProjectForAOTOnHelix.proj, and /datadisks/disk1/work/A8C00962/w/AD6509B4/e/publish/ProxyProjectForAOTOnHelix.props. **
  AOT'ing 55 assemblies
  [1/55] System.ObjectModel.dll -> System.ObjectModel.dll.bc
  [2/55] System.Private.CoreLib.dll -> System.Private.CoreLib.dll.bc
  [3/55] System.Private.Runtime.InteropServices.JavaScript.dll -> System.Private.Runtime.InteropServices.JavaScript.dll.bc
  [4/55] System.Private.Uri.dll -> System.Private.Uri.dll.bc
  [5/55] System.Private.Xml.dll -> System.Private.Xml.dll.bc
  [6/55] System.Private.Xml.Linq.dll -> System.Private.Xml.Linq.dll.bc
  [7/55] System.Reflection.Metadata.dll -> System.Reflection.Metadata.dll.bc
  [8/55] System.Reflection.TypeExtensions.dll -> System.Reflection.TypeExtensions.dll.bc
  [9/55] System.Runtime.CompilerServices.Unsafe.dll -> System.Runtime.CompilerServices.Unsafe.dll.bc
  [10/55] System.Runtime.dll -> System.Runtime.dll.bc
  [11/55] System.Runtime.InteropServices.RuntimeInformation.dll -> System.Runtime.InteropServices.RuntimeInformation.dll.bc
  [12/55] System.Runtime.Numerics.dll -> System.Runtime.Numerics.dll.bc
  [13/55] System.Runtime.Serialization.Primitives.dll -> System.Runtime.Serialization.Primitives.dll.bc
  [14/55] System.Security.Claims.dll -> System.Security.Claims.dll.bc
  [15/55] System.Security.Cryptography.Algorithms.dll -> System.Security.Cryptography.Algorithms.dll.bc
  [16/55] System.Security.Cryptography.Primitives.dll -> System.Security.Cryptography.Primitives.dll.bc
  [17/55] System.Security.Principal.Windows.dll -> System.Security.Principal.Windows.dll.bc
  [18/55] System.Text.RegularExpressions.dll -> System.Text.RegularExpressions.dll.bc
  [19/55] System.Text.RegularExpressions.Generator.dll -> System.Text.RegularExpressions.Generator.dll.bc
  [20/55] System.Text.RegularExpressions.Generators.Tests.dll -> System.Text.RegularExpressions.Generators.Tests.dll.bc
  [21/55] System.Threading.Tasks.Parallel.dll -> System.Threading.Tasks.Parallel.dll.bc
  [22/55] TestUtilities.dll -> TestUtilities.dll.bc
  [23/55] WasmTestRunner.dll -> WasmTestRunner.dll.bc
  [24/55] xunit.abstractions.dll -> xunit.abstractions.dll.bc
  [25/55] xunit.assert.dll -> xunit.assert.dll.bc
  [26/55] xunit.core.dll -> xunit.core.dll.bc
  [27/55] xunit.execution.dotnet.dll -> xunit.execution.dotnet.dll.bc
  [28/55] xunit.runner.utility.netcoreapp10.dll -> xunit.runner.utility.netcoreapp10.dll.bc
  [29/55] Microsoft.CodeAnalysis.dll -> Microsoft.CodeAnalysis.dll.bc
  [30/55] Microsoft.CodeAnalysis.Workspaces.dll -> Microsoft.CodeAnalysis.Workspaces.dll.bc
  [31/55] Microsoft.DotNet.XHarness.TestRunners.Xunit.dll -> Microsoft.DotNet.XHarness.TestRunners.Xunit.dll.bc
  [32/55] Microsoft.DotNet.XUnitExtensions.dll -> Microsoft.DotNet.XUnitExtensions.dll.bc
  [33/55] Microsoft.Win32.Registry.dll -> Microsoft.Win32.Registry.dll.bc
  [34/55] System.Collections.Concurrent.dll -> System.Collections.Concurrent.dll.bc
  [35/55] System.Collections.dll -> System.Collections.dll.bc
  [36/55] System.Collections.Immutable.dll -> System.Collections.Immutable.dll.bc
  [37/55] System.Collections.NonGeneric.dll -> System.Collections.NonGeneric.dll.bc
  [38/55] System.ComponentModel.Primitives.dll -> System.ComponentModel.Primitives.dll.bc
  [39/55] System.ComponentModel.TypeConverter.dll -> System.ComponentModel.TypeConverter.dll.bc
  [40/55] System.Composition.AttributedModel.dll -> System.Composition.AttributedModel.dll.bc
  [41/55] System.Composition.Hosting.dll -> System.Composition.Hosting.dll.bc
  [42/55] System.Composition.Runtime.dll -> System.Composition.Runtime.dll.bc
  [43/55] System.Composition.TypedParts.dll -> System.Composition.TypedParts.dll.bc
  [44/55] System.Console.dll -> System.Console.dll.bc
  [45/55] System.Diagnostics.Process.dll -> System.Diagnostics.Process.dll.bc
  [46/55] System.Diagnostics.TraceSource.dll -> System.Diagnostics.TraceSource.dll.bc
  [47/55] System.dll -> System.dll.bc
  [48/55] System.Globalization.dll -> System.Globalization.dll.bc
  [49/55] System.IO.Compression.dll -> System.IO.Compression.dll.bc
  [50/55] System.IO.MemoryMappedFiles.dll -> System.IO.MemoryMappedFiles.dll.bc
  [51/55] System.Linq.dll -> System.Linq.dll.bc
  [52/55] Microsoft.CodeAnalysis.CSharp.dll -> Microsoft.CodeAnalysis.CSharp.dll.bc
  [53/55] System.Linq.Expressions.dll -> System.Linq.Expressions.dll.bc
  [54/55] System.Net.Http.dll -> System.Net.Http.dll.bc
  [55/55] System.Net.Primitives.dll -> System.Net.Primitives.dll.bc
  result: True
  Compiling native assets with emcc. This may take a while ...
  [1/3] pinvoke.c -> pinvoke.o [took 0.181s]
  [2/3] driver.c -> driver.o [took 0.294s]
  [3/3] corebindings.c -> corebindings.o [took 0.611s]
  Compiling assembly bitcode files...
  [1/55] System.ObjectModel.dll.bc -> System.ObjectModel.dll.o [took 0.492s]
  [2/55] System.Private.CoreLib.dll.bc -> System.Private.CoreLib.dll.o [took 78.758s]
  [3/55] System.Private.Runtime.InteropServices.JavaScript.dll.bc -> System.Private.Runtime.InteropServices.JavaScript.dll.o [took 6.465s]
  [4/55] System.Private.Uri.dll.bc -> System.Private.Uri.dll.o [took 5.166s]
  [5/55] System.Private.Xml.dll.bc -> System.Private.Xml.dll.o [took 31.995s]
  [6/55] System.Private.Xml.Linq.dll.bc -> System.Private.Xml.Linq.dll.o [took 3.050s]
  [7/55] System.Reflection.Metadata.dll.bc -> System.Reflection.Metadata.dll.o [took 62.294s]
  [8/55] System.Reflection.TypeExtensions.dll.bc -> System.Reflection.TypeExtensions.dll.o [took 0.196s]
  [9/55] System.Runtime.CompilerServices.Unsafe.dll.bc -> System.Runtime.CompilerServices.Unsafe.dll.o [took 0.189s]
  [10/55] System.Runtime.dll.bc -> System.Runtime.dll.o [took 0.169s]
  [11/55] System.Runtime.InteropServices.RuntimeInformation.dll.bc -> System.Runtime.InteropServices.RuntimeInformation.dll.o [took 0.747s]
  [12/55] System.Runtime.Numerics.dll.bc -> System.Runtime.Numerics.dll.o [took 4.836s]
  [13/55] System.Runtime.Serialization.Primitives.dll.bc -> System.Runtime.Serialization.Primitives.dll.o [took 0.216s]
  [14/55] System.Security.Claims.dll.bc -> System.Security.Claims.dll.o [took 0.438s]
  [15/55] System.Security.Cryptography.Algorithms.dll.bc -> System.Security.Cryptography.Algorithms.dll.o [took 1.977s]
  [16/55] System.Security.Cryptography.Primitives.dll.bc -> System.Security.Cryptography.Primitives.dll.o [took 1.124s]
  [17/55] System.Security.Principal.Windows.dll.bc -> System.Security.Principal.Windows.dll.o [took 0.232s]
  [18/55] System.Text.RegularExpressions.dll.bc -> System.Text.RegularExpressions.dll.o [took 9.413s]
  [19/55] System.Text.RegularExpressions.Generator.dll.bc -> System.Text.RegularExpressions.Generator.dll.o [took 12.563s]
  [20/55] System.Text.RegularExpressions.Generators.Tests.dll.bc -> System.Text.RegularExpressions.Generators.Tests.dll.o [took 3.941s]
  [21/55] System.Threading.Tasks.Parallel.dll.bc -> System.Threading.Tasks.Parallel.dll.o [took 0.539s]
  [22/55] TestUtilities.dll.bc -> TestUtilities.dll.o [took 2.507s]
  [23/55] WasmTestRunner.dll.bc -> WasmTestRunner.dll.o [took 0.691s]
  [24/55] xunit.abstractions.dll.bc -> xunit.abstractions.dll.o [took 0.181s]
  [25/55] xunit.assert.dll.bc -> xunit.assert.dll.o [took 3.318s]
  [26/55] xunit.core.dll.bc -> xunit.core.dll.o [took 2.930s]
  [27/55] xunit.execution.dotnet.dll.bc -> xunit.execution.dotnet.dll.o [took 12.705s]
  [28/55] xunit.runner.utility.netcoreapp10.dll.bc -> xunit.runner.utility.netcoreapp10.dll.o [took 15.954s]
Killed
['System.Text.RegularExpressions.Generators.Tests' END OF WORK ITEM LOG: Command timed out, and was killed]

[eerhardt]

the Browser wasm AOT leg here is deterministically timing out / getting killed

We saw a similar thing in the STJ source generator as well. See #59042 (comment). But that was recently re-enabled with https://github.com/dotnet/runtime/pull/59396/files.

cc @radical

[stephentoub]

Thanks, @eerhardt. I opened an issue to track it and added a commit to suppress the tests.