Skip to content

Do not flush serializer buffers before first IAsyncEnumerable element is fetched #59808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eiriktsarpalis merged 3 commits into from
Oct 1, 2021
Merged

Do not flush serializer buffers before first IAsyncEnumerable element is fetched #59808

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
95e7b16
Do not flush serializer buffers before first IAsyncEnumerable element…
eiriktsarpalis Sep 30, 2021
85f710a
add debug assertion
eiriktsarpalis Oct 1, 2021
0de247e
address feedback
eiriktsarpalis Oct 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
address feedback
  • Loading branch information
@eiriktsarpalis
eiriktsarpalis committed Oct 1, 2021
commit 0de247e9eb3098afc95c194bcc85f939e8c6f121
1 change: 1 addition & 0 deletions ...raries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializer.Write.Stream.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,6 +332,7 @@ private static async Task WriteStreamAsync<TValue>(

if (state.SuppressFlush)
{
Debug.Assert(!isFinalBlock);
Debug.Assert(state.PendingTask is not null);
state.SuppressFlush = false;
}
Expand Down