Skip to content

[release/6.0] Produce symbols archives #59843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Anipik merged 2 commits into from
Oct 8, 2021
Merged

[release/6.0] Produce symbols archives #59843

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7577b8c
Produce symbols archives.
jkoritzinsky Sep 30, 2021
657995c
Backport official build fix from #60096 to keep this PR from breaking…
jkoritzinsky Oct 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Backport official build fix from #60096 to keep this PR from breaking… 
… the official build.
  • Loading branch information
@jkoritzinsky
jkoritzinsky committed Oct 8, 2021
commit 657995c0f8ed6d2131cea46746eca30004feef48
2 changes: 1 addition & 1 deletion src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Runtime.Composite.sfxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<ArchiveName>dotnet-runtime-internal-composite</ArchiveName>
<OverridePackageId>$(SharedFrameworkName).Composite</OverridePackageId>
<OverridePackageId Condition="'$(PgoInstrument)' != ''">$(SharedFrameworkName).Composite.PGO</OverridePackageId>
<CreateSymbolsArchive>true</CreateSymbolsArchive>
<CreateSymbolsArchive Condition="'$(PgoInstrument)' == ''">true</CreateSymbolsArchive>
<SymbolsArchiveName>dotnet-runtime-composite-symbols</SymbolsArchiveName>
<UseTemplatedPlatformManifest>true</UseTemplatedPlatformManifest>
<ForcePublishReadyToRunComposite>true</ForcePublishReadyToRunComposite>
Expand Down
2 changes: 1 addition & 1 deletion src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Runtime.sfxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<InstallerName Condition="'$(TargetOS)' != 'OSX'">dotnet-runtime</InstallerName>
<InstallerName Condition="'$(TargetOS)' == 'OSX'">dotnet-runtime-internal</InstallerName>
<OverridePackageId Condition="'$(PgoInstrument)' != ''">$(SharedFrameworkName).PGO</OverridePackageId>
<CreateSymbolsArchive>true</CreateSymbolsArchive>
<CreateSymbolsArchive Condition="'$(PgoInstrument)' == ''">true</CreateSymbolsArchive>
<SymbolsArchiveName>dotnet-runtime-symbols</SymbolsArchiveName>
<VSInsertionShortComponentName>NetCore.SharedFramework</VSInsertionShortComponentName>
<UseTemplatedPlatformManifest>true</UseTemplatedPlatformManifest>
Expand Down