Prevent runtime prop metadata retrieval when [JsonIgnore] is used #60024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-text-json |
src/libraries/System.Text.Json/gen/JsonSourceGenerator.Emitter.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/tests/Common/TestClasses/TestClasses.Constructor.cs
Outdated
Show resolved
Hide resolved
layomia
force-pushed
the
JsonIgnore
branch
2 times, most recently
from
c43b151 to
ffb733f
Compare
layomia
commented
Oct 6, 2021
...braries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.ParameterMatching.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.cs
Outdated
Show resolved
Hide resolved
...braries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.ParameterMatching.cs
Outdated
Show resolved
Hide resolved
layomia
force-pushed
the
JsonIgnore
branch
5 times, most recently
from
d901f29 to
6112780
Compare
steveharter
reviewed
Oct 11, 2021
steveharter
reviewed
Oct 11, 2021
...ibraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/GenericMethodHolder.cs
Outdated
Show resolved
Hide resolved
layomia
force-pushed
the
JsonIgnore
branch
2 times, most recently
from
08945c3 to
ae2f69c
Compare
steveharter
approved these changes
Oct 11, 2021
Contributor
steveharter
left a comment
steveharter
left a comment
There was a problem hiding this comment.
LGTM assuming green CI
| JsonSerializerOptions options) | ||
| { | ||
| JsonPropertyInfo jsonPropertyInfo = converter.CreateJsonPropertyInfo(); | ||
| JsonPropertyInfo jsonPropertyInfo = new JsonPropertyInfo<sbyte>(); |
Member
There was a problem hiding this comment.
Could you also add a comment here explaining why sbyte is being used?
Contributor
Author
There was a problem hiding this comment.
Will be sure to do so in a follow up to avoid CI reset. It will be the same as the comment on CreateIgnoredParameterPlaceholder below.
eiriktsarpalis
approved these changes
Oct 12, 2021
Contributor
Author
|
Test failures unrelated. |
Contributor
Author
|
/backport to release/6.0 |
Contributor
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1333901172 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59936, a 6.0 regression. Contributes to #59364.