[wasm][debugger] Avoid using Uint8Array to set memory content #60087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But I'm not using Uint8Array to set the content on memory allocated using malloc as @lewing suggested in the same PR.
|
Tagging subscribers to this area: @thaystg |
|
Tagging subscribers to 'arch-wasm': @lewing |
kg
reviewed
Oct 6, 2021
kg
approved these changes
Oct 6, 2021
Member
kg
left a comment
kg
left a comment
There was a problem hiding this comment.
Looks fine, and you can do the single malloc like before if you want
radical
reviewed
Oct 6, 2021
| } | ||
|
|
||
| [Fact] | ||
| public async Task MallocUntilReallocate() //https://github.com/xamarin/xamarin-android/issues/6161 |
Member
There was a problem hiding this comment.
- Should this maybe pause/inspect/resume through one breakpoint first, then call
malloc_to_reallocate_test, and then try the breakpoint again? - Can we add something in the test to confirm that the memory grew?
Member
Author
There was a problem hiding this comment.
- Why it would be good to test a breakpoint first? I think it's not necessary, if I remove the fix on [wasm][debugger] Fix reusing buffer for debugger #59773, I can perfectly reproduce the behavior that we were getting when debugging from VS.
- I'm not sure, I'll try to find a way to detect it.
Member
There was a problem hiding this comment.
- Why it would be good to test a breakpoint first?
I was thinking that it would ensure that the debugger buffer had been used at least once. But that would get used to even get started with debugging, IIUC, so you are correct - this isn't needed 👍
- I'm not sure, I'll try to find a way to detect it.
Maybe even a simple - UInt8Array before the growth, and then checking that it got reset?
radical
reviewed
Oct 6, 2021
lewing
approved these changes
Oct 7, 2021
radical
approved these changes
Oct 7, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a test case for PR #59773
But I'm not using Uint8Array to set the content on memory allocated using malloc as @lewing suggested in the same PR.