Skip to content

[release/6.0] Update THIRD-PARTY-NOTICES.TXT #60092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NikolaMilosavljevic merged 4 commits into from
Oct 18, 2021
Merged

[release/6.0] Update THIRD-PARTY-NOTICES.TXT #60092

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fe51373
Update THIRD-PARTY-NOTICES.TXT
NikolaMilosavljevic Oct 6, 2021
2924664
Regenerating to incorporate a change in infra
NikolaMilosavljevic Oct 7, 2021
5baf9ae
Fixes for duplicate instance and misplaced header
NikolaMilosavljevic Oct 13, 2021
9316650
Remove duplicate corefx header
NikolaMilosavljevic Oct 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixes for duplicate instance and misplaced header
  • Loading branch information
@NikolaMilosavljevic
NikolaMilosavljevic committed Oct 13, 2021
commit 5baf9aeb6121ed3a5dbc90cf0de22bbcfe543abc
31 changes: 3 additions & 28 deletions src/installer/pkg/THIRD-PARTY-NOTICES.TXT
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -971,6 +971,7 @@ SUCH DAMAGE.

License notice for Angular v8.0
--------------------------------
Copy link
Contributor

@dougbu dougbu Oct 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a blank line after this for consistency

Copy link
Member Author

@NikolaMilosavljevic NikolaMilosavljevic Oct 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is coming from dotnet/aspnetcore - we could fix it here, but it should also be fixed in source location to not regress in the future.

Copy link
Member Author

@NikolaMilosavljevic NikolaMilosavljevic Oct 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.


The MIT License (MIT)
=====================

Expand All @@ -994,8 +995,6 @@ LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE SOFTWARE.

License notice for corefx

License notice for BedrockFramework
===================================

Expand Down Expand Up @@ -1322,31 +1321,6 @@ License for fastmod (https://github.com/lemire/fastmod) and ibm-fpgen (https://g
See the License for the specific language governing permissions and
limitations under the License.

License notice for Angular v8.0
--------------------------------------------
The MIT License (MIT)
=====================

Copyright (c) 2010-2019 Google LLC. http://angular.io/license

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE SOFTWARE.

License notice for corefx
Copy link
Contributor

@dougbu dougbu Oct 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a dangling header

Copy link
Member Author

@NikolaMilosavljevic NikolaMilosavljevic Oct 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed - removed.


License notice for JavaScript queues
Expand Down Expand Up @@ -1475,7 +1449,8 @@ LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.

------------------------------------------------
License notice for corefx
-------------------------------------

The MIT License (MIT)
Copy link
Contributor

@sharwell sharwell Oct 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❔ Which one is this associated with?

Copy link
Member Author

@NikolaMilosavljevic NikolaMilosavljevic Oct 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is coming from dotnet/aspnetcore/main/THIRD-PARTY-NOTICES.txt line 194

Copy link
Contributor

@dougbu dougbu Oct 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/dotnet/aspnetcore/blob/main/THIRD-PARTY-NOTICES.txt line 194 is blank and I suspect this should be under the License notice for corefx title above. See https://github.com/dotnet/runtime/pull/60092/files#diff-1f7876cafb24ce314004bb439a08320edba033f8a8a43d1961009f1088bd43d3R1350

Copy link
Member Author

@NikolaMilosavljevic NikolaMilosavljevic Oct 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing.


Expand Down