Skip to content

[release/6.0] SafeFileHandle.Unix: don't DeleteOnClose when lock is not successful. #60112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danmoseley merged 2 commits into from
Oct 8, 2021
Merged

[release/6.0] SafeFileHandle.Unix: don't DeleteOnClose when lock is not successful. #60112

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77a3813
SafeFileHandle.Unix: don't DeleteOnClose when lock is not succesful.
tmds Oct 7, 2021
bb68d38
test: add ConditionalFact IsFileLockingEnabled
tmds Oct 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: add ConditionalFact IsFileLockingEnabled
  • Loading branch information
@tmds
tmds committed Oct 7, 2021
commit bb68d384b1ee1fc68b9e1d89af9a4b1c205a0b9d
2 changes: 1 addition & 1 deletion src/libraries/System.IO.FileSystem/tests/FileStream/SafeFileHandle.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ public async Task ThrowWhenHandlePositionIsChanged_async()
await ThrowWhenHandlePositionIsChanged(useAsync: true);
}

[Fact]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsFileLockingEnabled))]
public void DeleteOnClose_FailedShareDoesNotDeleteFile()
{
string fileName = GetTestFilePath();
Expand Down