Skip to content

FileSystemEntry.Unix: ensure properties are available when file is deleted. #60214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamsitnik merged 12 commits into from
Nov 18, 2021
Merged

FileSystemEntry.Unix: ensure properties are available when file is deleted. #60214

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
47183e9
FileSystemEntry.Unix: ensure attributes are available when file is de…
tmds Oct 9, 2021
8a0edcd
GetLength: fix reading from uninitialized cache.
tmds Oct 9, 2021
ed16197
Update test
tmds Oct 11, 2021
794f2b2
Add a comment to GetLength about the value it returns for symlinks.
tmds Oct 11, 2021
5322a6b
Always assert entry.Length on Unix
tmds Oct 11, 2021
2031b64
Minor refactoringcd
tmds Oct 11, 2021
4e6f8fc
Add message to each assert.
tmds Oct 11, 2021
4fd4f6b
test: update expected values for Browser platform
tmds Oct 11, 2021
27ef95c
Reorder test asserts and add some comments.
tmds Oct 11, 2021
c1fe08f
Fix indentation.
tmds Oct 12, 2021
4cd2e99
Also use symbolic links in the test
tmds Nov 3, 2021
3a7356e
PR feedback
tmds Nov 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
GetLength: fix reading from uninitialized cache.
  • Loading branch information
@tmds
tmds committed Oct 9, 2021
commit 8a0edcd2bf1e2fd8b872a2656f4da4e3299a6abf
2 changes: 1 addition & 1 deletion src/libraries/System.Private.CoreLib/src/System/IO/FileStatus.Unix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ private unsafe void SetAccessOrWriteTime(string path, DateTimeOffset time, bool
internal long GetLength(ReadOnlySpan<char> path, bool continueOnError = false)
{
EnsureCachesInitialized(path, continueOnError);
return _fileCache.Size;
return IsFileCacheInitialized ? _fileCache.Size : 0;
}

// Tries to refresh the lstat cache (_fileCache).
Expand Down