Skip to content

Use Span.Fill in String(Char, Int32) constructor #60269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamsitnik merged 3 commits into from
Nov 15, 2021
Merged

Use Span.Fill in String(Char, Int32) constructor #60269

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c4eff1
Implementation
SteveDunn Oct 11, 2021
a05de4b
Apply suggestions from code review
adamsitnik Nov 15, 2021
8d033b3
Apply suggestions from code review
adamsitnik Nov 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Jeremy Koritzinsky <[email protected]>
  • Loading branch information
@adamsitnik @jkoritzinsky
adamsitnik and jkoritzinsky authored Nov 15, 2021
commit a05de4b2a4d26b671a07e83a3e73d519926b155b
10 changes: 6 additions & 4 deletions src/libraries/System.Private.CoreLib/src/System/String.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,10 +320,12 @@ string Ctor(char c, int count)
throw new ArgumentOutOfRangeException(nameof(count), SR.ArgumentOutOfRange_NegativeCount);
}

char[] arr = new char[count];
Span<char> s = new(arr);
s.Fill(c);
return new(s);
string result = FastAllocateString(count);
if (c != '\0')
{
MemoryMarshal.CreateSpan(ref result._firstChar, count).Fill(c);
}
return result;
}

[MethodImpl(MethodImplOptions.InternalCall)]
Expand Down