Skip to content

[release/6.0] Fallback to read/write if pread/pwrite fails #60280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Anipik merged 13 commits into from
Oct 12, 2021
Merged

[release/6.0] Fallback to read/write if pread/pwrite fails #60280

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ce3a5d2
Fallback to read/write if pread/pwrite fails
Sep 30, 2021
3c9804e
* Cache whether a handle supports random access * Keep avoiding pread…
Oct 4, 2021
5d9d9ae
Test more device paths and add tests for WriteAll*
Oct 4, 2021
d6bfc02
Fix CI: skip test when device can't be opened
Oct 4, 2021
f4ae895
* Do not use SkipTestException * Exclude EBADF from assertion
Oct 4, 2021
a9674d0
use NullableBool in _supportsRandomAccess
jozkee Oct 4, 2021
754d6d5
Add tests for mkfifo and socketpair
jozkee Oct 6, 2021
4383315
Rename test file
jozkee Oct 6, 2021
3d8adf1
Address feedback in src
jozkee Oct 6, 2021
733371a
Address suggestions
jozkee Oct 7, 2021
ae00ff5
Address suggestions
jozkee Oct 8, 2021
74fef71
Update src/libraries/System.IO.FileSystem/tests/FileStream/DevicesPip…
jozkee Oct 11, 2021
20e5d34
Use IEnumerable<string> in Lazy and fix usages
jozkee Oct 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use NullableBool in _supportsRandomAccess
  • Loading branch information
@jozkee
jozkee authored and github-actions committed Oct 12, 2021
commit a9674d021374c34644d2d86dedd2c5290f29763b
14 changes: 11 additions & 3 deletions src/libraries/System.Private.CoreLib/src/Microsoft/Win32/SafeHandles/SafeFileHandle.Unix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ public sealed partial class SafeFileHandle : SafeHandleZeroOrMinusOneIsInvalid

// not using bool? as it's not thread safe
private volatile NullableBool _canSeek = NullableBool.Undefined;
private volatile NullableBool _supportsRandomAccess = NullableBool.Undefined;
private bool _deleteOnClose;
private bool _isLocked;

Expand All @@ -33,11 +34,18 @@ private SafeFileHandle(bool ownsHandle)

internal bool CanSeek => !IsClosed && GetCanSeek();

private bool? _supportsRandomAccess;
internal bool SupportsRandomAccess
{
get => _supportsRandomAccess ??= CanSeek;
set => _supportsRandomAccess = value;
get
{
if (_supportsRandomAccess == NullableBool.Undefined)
{
_supportsRandomAccess = GetCanSeek() ? NullableBool.True : NullableBool.False;
}

return _supportsRandomAccess == NullableBool.True;
}
set => _supportsRandomAccess = value ? NullableBool.True : NullableBool.False;
}

internal ThreadPoolBoundHandle? ThreadPoolBinding => null;
Expand Down