Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Suspend exception when trying to change the timer
  • Loading branch information
sakno committed Oct 12, 2021
commit 0aa4c6fc66334c8cab94b39ca7b46ce1d3727131
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@ public bool TryReset()
// If we successfully reset it and it never fired, then we can be sure it won't trigger cancellation.
bool reset =
_timer is not TimerQueueTimer timer ||
(timer.Change(Timeout.UnsignedInfinite, Timeout.UnsignedInfinite) && !timer._everQueued);
(timer.Change(Timeout.UnsignedInfinite, Timeout.UnsignedInfinite, throwIfDisposed: false) && !timer._everQueued);

if (reset)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -515,14 +515,14 @@ internal string DisplayString
}
}

internal bool Change(uint dueTime, uint period)
internal bool Change(uint dueTime, uint period, bool throwIfDisposed = true)
{
bool success;

lock (_associatedTimerQueue)
{
if (_canceled)
throw new ObjectDisposedException(null, SR.ObjectDisposed_Generic);
return throwIfDisposed ? throw new ObjectDisposedException(null, SR.ObjectDisposed_Generic) : false;

_period = period;

Expand Down