[reflection] Initialize default ALC gchandle in GetLoadContext #60350
Conversation
If we try to get the ALC of an assembly from the default context before the managed default ALC object has been created, the native gchandle has a null target. Ensure it is not null by explicitly referencing the Default ALC. Fixes dotnet#60348
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
lambdageek
added
the
area-VM-reflection-mono
|
Tagging subscribers to this area: Issue DetailsIf we try to get the ALC of an assembly from the default context before the Fixes #60348
|
|
@lambdageek worth the backport? |
If possible, I'd like to see this fix backported, since it fixes a serious problem - without that patch, the github runner crashes on startup, and the runner is definitely one of the apps we want to run on s390x. Also, that pattern of installing an Unloading handler (which is triggering the crash) seems one that is probably used elsewhere too. |
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1341836876 |
ghost
locked as resolved and limited conversation to collaborators
6 participants
If we try to get the ALC of an assembly from the default context before the
managed default ALC object has been created, the native gchandle has a null
target.
Ensure it is not null by explicitly referencing the Default ALC.
Fixes #60348