Skip to content

[release/6.0] Fix Int32 overflow bug in buffering logic #60460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danmoseley merged 7 commits into from
Oct 18, 2021
Merged

[release/6.0] Fix Int32 overflow bug in buffering logic #60460

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c8f0459
add a failing test
adamsitnik Oct 15, 2021
597b5d0
fix the bug in BufferedFileStreamStrategy
adamsitnik Oct 15, 2021
57c73a1
extend the test and fix it in the BufferedStream as well
adamsitnik Oct 15, 2021
a7e77b5
large files are currently not supported on WASM
adamsitnik Oct 15, 2021
783eb1e
Apply suggestions from code review
adamsitnik Oct 15, 2021
1fbb550
Exclude test from running in 32 bits
jozkee Oct 16, 2021
97f143e
fix the ConditionalFact attribute usage
adamsitnik Oct 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
large files are currently not supported on WASM
  • Loading branch information
@adamsitnik
adamsitnik committed Oct 15, 2021
commit a7e77b5f6983b0607b68f63a52d5c8ddeaf2774f
1 change: 1 addition & 0 deletions src/libraries/System.IO.FileSystem/tests/FileStream/Read.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ public void NegativeReadRootThrows()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/45954", TestPlatforms.Browser)]
public void NoInt32OverflowInTheBufferingLogic()
{
const long positon1 = 10;
Expand Down