Skip to content

Rerun mobile target jobs when it fails for 4 known scenarios #60475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fanyang-mono merged 4 commits into from
Oct 21, 2021
Merged

Rerun mobile target jobs when it fails for 4 known scenarios #60475

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d23c2b4
Rerun jobs when it fails for 4 known scenarios
fanyang-mono Oct 15, 2021
c8f3b4f
Add exitcode to retry files
fanyang-mono Oct 20, 2021
6dfd42a
Add app name to retry files
fanyang-mono Oct 20, 2021
101ca76
Fix callsite
fanyang-mono Oct 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions src/tests/Common/Coreclr.TestWrapper/MobileAppHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,12 @@ private static int HandleMobileApp(string action, string platform, string catego
{
//install or uninstall mobile app
int exitCode = -100;

if (action == "install" && (File.Exists($"{testBinaryBase}/.retry") || File.Exists($"{testBinaryBase}/.reboot")))
{
return exitCode;
}

string outputFile = Path.Combine(reportBase, action, $"{category}_{action}.output.txt");
string errorFile = Path.Combine(reportBase, action, $"{category}_{action}.error.txt");
bool platformValueFlag = true;
Expand Down Expand Up @@ -81,6 +87,11 @@ private static int HandleMobileApp(string action, string platform, string catego
}
}

if (action == "install")
{
cmdStr += " --timeout 00:05:00";
}

using (Process process = new Process())
{
if (OperatingSystem.IsWindows())
Expand Down Expand Up @@ -108,6 +119,19 @@ private static int HandleMobileApp(string action, string platform, string catego
{
// Process completed.
exitCode = process.ExitCode;

// See https://github.com/dotnet/xharness/blob/main/src/Microsoft.DotNet.XHarness.Common/CLI/ExitCode.cs
// 78 - PACKAGE_INSTALLATION_FAILURE
// 81 - DEVICE_NOT_FOUND
// 85 - ADB_DEVICE_ENUMERATION_FAILURE
// 86 - PACKAGE_INSTALLATION_TIMEOUT
if (action == "install" && (exitCode == 78 || exitCode == 81|| exitCode == 85|| exitCode == 86))
{
CreateRetryFile($"{testBinaryBase}/.retry", exitCode, category);
CreateRetryFile($"{testBinaryBase}/.reboot", exitCode, category);
return exitCode;
}

Task.WaitAll(copyOutput, copyError);
}
else
Expand Down Expand Up @@ -155,5 +179,13 @@ private static string ConvertCmd2Arg(string cmd)

return $"{cmdPrefix} \"{cmd}\"";
}

private static void CreateRetryFile(string fileName, int exitCode, string appName)
{
using (StreamWriter writer = new StreamWriter(fileName))
{
writer.WriteLine($"appName: {appName}; exitCode: {exitCode}");
}
}
}
}