Skip to content

[release/6.0] DotNetHost packages are not created during source-build #60577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Anipik merged 1 commit into from
Nov 9, 2021
Merged

[release/6.0] DotNetHost packages are not created during source-build #60577

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
DotNetHost packages are not created during source-build 
The subset `host.pkg` is not producing the DotNetHost* NuGet packages. This is because the "Pack" target is getting invoked on the pkgprojs, but pkgprojs expect the "Build" target to be called. Since the "Pack" target is overriden in the Directory.Build.targets to be empty, no one is calling the "Build" target on the pkgprojs.

In an official build, a later subset `packs.tests` comes through and builds `Microsoft.DotNet.CoreSetup.Packaging.Tests.csproj`, which explicitly calls "Build" on the pkgprojs. So official builds still get these packages produced.

In source-build, we are no longer building the `packs.tests` subset, so the packages are not produced.
  • Loading branch information
@eerhardt
eerhardt authored and github-actions committed Oct 18, 2021
commit 68cd4ec5ec072a612f6848099e8fd566fc1ffa27
2 changes: 1 addition & 1 deletion src/installer/Directory.Build.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@
<Import Project="..\..\Directory.Build.targets" />

<!-- Provide default targets which can be hooked onto or overridden as necessary -->
<Target Name="Pack" />
<Target Name="Pack" DependsOnTargets="Build" />
</Project>