Skip to content

Conversation

@jozkee
Copy link
Member

@jozkee jozkee commented Oct 19, 2021

Related to #49104. I just need to make sure that this is also working in .NET 6 to confirm that nothing needs to be backported.

cc @danmoseley @stephentoub do you know if there were some recent string changes?

@jozkee jozkee added this to the 7.0.0 milestone Oct 19, 2021
@jozkee jozkee self-assigned this Oct 19, 2021
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Some unrelated test project has failed (System.IO.FileSystem.Tests), I am going to re-run it.

The failure log is not very helpful: https://helix.dot.net/api/2019-06-17/jobs/54e26cdc-2173-4da5-971a-376463bf1f36/workitems/System.IO.FileSystem.Tests/console

@carlossanlop
Copy link
Contributor

@jozkee do you know what got the originally issue fixed?

@jozkee
Copy link
Member Author

jozkee commented Oct 19, 2021

@carlossanlop not yet, that's what I am looking for.

@jozkee
Copy link
Member Author

jozkee commented Oct 19, 2021

Not sure what fixed this but I am unable to repro it on release/6.0 latest bits. That should be good enough.

@jozkee jozkee merged commit ccf9130 into dotnet:main Oct 19, 2021
@jozkee jozkee deleted the re-enable-memmapfile branch October 19, 2021 22:10
@jozkee
Copy link
Member Author

jozkee commented Oct 19, 2021

The failure log is not very helpful: https://helix.dot.net/api/2019-06-17/jobs/54e26cdc-2173-4da5-971a-376463bf1f36/workitems/System.IO.FileSystem.Tests/console

@adamsitnik if you remove the last piece of the path (console) and then you go to the link in the JSON property FileName you can find the actual console log: "FileName":"console.13fc2650.log","Uri":"https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-60609-merge-54e26cdc21734da597/System.IO.FileSystem.Tests/1/console.13fc2650.log?sv=2019-07-07&se=2021-11-08T04%3A39%3A14Z&sr=c&sp=rl&sig=Rz6IJcRHcwqUCNrFoM0GkkVO5K66DRBItDdC%2FJ4MX40%3D"

Not sure why that's not the link shown in dnceng (cc @dotnet/runtime-infrastructure) but doing that you can see that the CI error is:

   System.IO.FileSystem.Tests: [Long Running Test] 'System.IO.Tests.FileStream_Read.NoInt32OverflowInTheBufferingLogic', Elapsed: 00:02:44
   System.IO.FileSystem.Tests: [Long Running Test] 'System.IO.Tests.FileStream_Read.NoInt32OverflowInTheBufferingLogic', Elapsed: 00:04:45
   System.IO.FileSystem.Tests: [Long Running Test] 'System.IO.Tests.FileStream_Read.NoInt32OverflowInTheBufferingLogic', Elapsed: 00:06:45
   System.IO.FileSystem.Tests: [Long Running Test] 'System.IO.Tests.FileStream_Read.NoInt32OverflowInTheBufferingLogic', Elapsed: 00:08:45
   System.IO.FileSystem.Tests: [Long Running Test] 'System.IO.Tests.FileStream_Read.NoInt32OverflowInTheBufferingLogic', Elapsed: 00:10:45
   System.IO.FileSystem.Tests: [Long Running Test] 'System.IO.Tests.FileStream_Read.NoInt32OverflowInTheBufferingLogic', Elapsed: 00:12:45
   System.IO.FileSystem.Tests: [Long Running Test] 'System.IO.Tests.FileStream_Read.NoInt32OverflowInTheBufferingLogic', Elapsed: 00:14:45
['System.IO.FileSystem.Tests' END OF WORK ITEM LOG: Command timed out, and was killed]

which should be fixed by #60606.

@ghost ghost locked as resolved and limited conversation to collaborators Nov 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants