Skip to content

Up retry for ETXTBSY #60741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
agocke merged 2 commits into from
Oct 26, 2021
Merged

Up retry for ETXTBSY #60741

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4a6581
Up retry for ETXTBSY
agocke Oct 21, 2021
633ca73
Linearly scale wait time
agocke Oct 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Up retry for ETXTBSY 
Still seeing occasional failure in Alpine
(https://dev.azure.com/dnceng/public/_build/results?buildId=1434759) so
raising the retry time.
  • Loading branch information
@agocke
agocke committed Oct 21, 2021
commit a4a6581e94eb673780b514959d3d993076af9d30
4 changes: 1 addition & 3 deletions src/installer/tests/TestUtils/Command.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,9 +208,7 @@ public Command Start()
}
catch (Win32Exception e) when (i < 3 && e.Message.Contains("Text file busy"))
{
// 10 ms is short, but the race we're trying to avoid is in-between
// "fork" and "exec", so it should be fast
Thread.Sleep(10);
Thread.Sleep(50);
Copy link
Member

@VSadov VSadov Oct 25, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now if we wait, we would wait at least 50ms. I think something like Sleep(i * 20) and limiting i < 4 could have better balance between common quick case and if needed a longer wait.

The nice part is that the fist iteration would be Sleep(0), which works like a machine-wide Yield, but without minimum wait.

}
}

Expand Down