Skip to content

[DllImportGenerator] Stop flagging methods with well-known unsupported types for conversion #60841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elinor-fung merged 4 commits into from
Oct 26, 2021
Merged

[DllImportGenerator] Stop flagging methods with well-known unsupported types for conversion #60841

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
12d1f96
Stop flagging methods with well-known unsupported types for conversion
elinor-fung Oct 22, 2021
36e5edf
Make fixer put attribute arguments in preferred order
elinor-fung Oct 25, 2021
dde7663
Update src/libraries/System.Runtime.InteropServices/gen/DllImportGene…
elinor-fung Oct 26, 2021
070b8d4
Merge branch 'main' into convertToGeneratedAnalyzer
elinor-fung Oct 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update src/libraries/System.Runtime.InteropServices/gen/DllImportGene… 
…rator/Analyzers/ConvertToGeneratedDllImportAnalyzer.cs

Co-authored-by: Adeel Mujahid <[email protected]>
  • Loading branch information
@elinor-fung @am11
elinor-fung and am11 authored Oct 26, 2021
commit dde7663230381ef54f06495ae3e4f34d3c4800c8
2 changes: 1 addition & 1 deletion ...e.InteropServices/gen/DllImportGenerator/Analyzers/ConvertToGeneratedDllImportAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public override void Initialize(AnalysisContext context)
if (generatedDllImportAttrType == null)
return;

List<ITypeSymbol> knownUnsupportedTypes = new List<ITypeSymbol>();
var knownUnsupportedTypes = new List<ITypeSymbol>(s_unsupportedTypeNames.Length);
foreach (string typeName in s_unsupportedTypeNames)
{
INamedTypeSymbol? unsupportedType = compilationContext.Compilation.GetTypeByMetadataName(typeName);
Expand Down