Skip to content

[release/6.0] Disable package validation in source-build for reliability #60881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Anipik merged 3 commits into from
Nov 9, 2021
Merged

[release/6.0] Disable package validation in source-build for reliability #60881

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
902cbd4
Disable package validation in source-build for reliability
dagood Oct 26, 2021
0f1a69f
Add tracking issue to comment
dagood Oct 26, 2021
9991cd7
Switch from property overwrite to a condition
dagood Oct 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion eng/packaging.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
<Project>

<PropertyGroup>
<EnablePackageValidation>true</EnablePackageValidation>
<!--
Package validation causes flaky errors during the build. Validation isn't useful during
source-build (it is only a guardrail for devs), so disable it during source-build to avoid the
impact on build reliability. https://github.com/dotnet/runtime/issues/60883 tracks fixing the
flakiness and removing this condition.
-->
<EnablePackageValidation Condition="'$(DotNetBuildFromSource)' != 'true'">true</EnablePackageValidation>
<!-- Don't restore prebuilt packages during sourcebuild. -->
<DisablePackageBaselineValidation Condition="'$(DotNetBuildFromSource)' == 'true'">true</DisablePackageBaselineValidation>
<PackageValidationBaselineVersion Condition="'$(PackageValidationBaselineVersion)' == ''">$([MSBuild]::Subtract($(MajorVersion), 1)).0.0</PackageValidationBaselineVersion>
Expand Down