Skip to content

[release/6.0] for non-seekable file handles, the OVERLAPPED offset must be set to 0 #60931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adamsitnik wants to merge 1 commit into from
Closed

[release/6.0] for non-seekable file handles, the OVERLAPPED offset must be set to 0 #60931

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
for non-seekable file handles, the OVERLAPPED offset must be set to 0
  • Loading branch information
@adamsitnik
adamsitnik committed Oct 27, 2021
commit b42a1ba4a7e8ad71fcf341791dcef2cfbb2dacc5
4 changes: 2 additions & 2 deletions src/libraries/System.Private.CoreLib/src/System/IO/Strategies/OSFileStreamStrategy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ public sealed override Task WriteAsync(byte[] buffer, int offset, int count, Can

public sealed override ValueTask WriteAsync(ReadOnlyMemory<byte> source, CancellationToken cancellationToken)
{
long writeOffset = CanSeek ? Interlocked.Add(ref _filePosition, source.Length) - source.Length : -1;
long writeOffset = CanSeek ? Interlocked.Add(ref _filePosition, source.Length) - source.Length : 0;
return RandomAccess.WriteAtOffsetAsync(_fileHandle, source, writeOffset, cancellationToken, this);
}

Expand All @@ -311,7 +311,7 @@ public sealed override ValueTask<int> ReadAsync(Memory<byte> destination, Cancel
{
if (!CanSeek)
{
return RandomAccess.ReadAtOffsetAsync(_fileHandle, destination, fileOffset: -1, cancellationToken);
return RandomAccess.ReadAtOffsetAsync(_fileHandle, destination, fileOffset: 0, cancellationToken);
}

if (LengthCachingSupported && _length >= 0 && Volatile.Read(ref _filePosition) >= _length)
Expand Down