Skip to content

Make QCalls respect the EntryPoint property #60992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkoritzinsky merged 14 commits into from
Nov 2, 2021
Merged

Make QCalls respect the EntryPoint property #60992

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
a131cad
Make QCalls respect the EntryPoint property
jkoritzinsky Oct 28, 2021
ae6a6cb
Fix some build issues on release and macos.
jkoritzinsky Oct 28, 2021
6576f91
Remove unnecessary CharSet applications
jkoritzinsky Oct 28, 2021
20f8eea
Remove usage of SystemNative_ prefix from within CoreCLR.
jkoritzinsky Oct 29, 2021
34f0f2b
PR feedback.
jkoritzinsky Oct 29, 2021
01a37df
Fix macos build failures.
jkoritzinsky Oct 29, 2021
75428fa
Restore one CharSet that I missed.
jkoritzinsky Oct 29, 2021
58308c2
Update system.h
jkoritzinsky Nov 1, 2021
5e3eae7
Fix entrypoint copy-paste bug.
jkoritzinsky Nov 1, 2021
900ea23
Remove COM+ legacy naming from new QCall entrypoints.
jkoritzinsky Nov 2, 2021
b9fbbf9
Apply suggestions from code review
jkoritzinsky Nov 2, 2021
3f9332d
Update src/coreclr/vm/commodule.h
jkoritzinsky Nov 2, 2021
088d1d4
Update src/coreclr/vm/runtimehandles.cpp
jkoritzinsky Nov 2, 2021
c553aab
PR feedback.
jkoritzinsky Nov 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix macos build failures.
  • Loading branch information
@jkoritzinsky
jkoritzinsky committed Oct 29, 2021
commit 01a37df8ea4c69d2ab31147d7a67220473479027
8 changes: 4 additions & 4 deletions src/coreclr/vm/interoplibinterface_objc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ namespace
}

extern "C" BOOL QCALLTYPE ObjCMarshal_TryInitializeReferenceTracker(
_In_ BeginEndCallback beginEndCallback,
_In_ IsReferencedCallback isReferencedCallback,
_In_ EnteredFinalizationCallback trackedObjectEnteredFinalization)
_In_ ObjCMarshalNative::BeginEndCallback beginEndCallback,
_In_ ObjCMarshalNative::IsReferencedCallback isReferencedCallback,
_In_ ObjCMarshalNative::EnteredFinalizationCallback trackedObjectEnteredFinalization)
{
QCALL_CONTRACT;
_ASSERTE(beginEndCallback != NULL
Expand Down Expand Up @@ -154,7 +154,7 @@ namespace
}

extern "C" BOOL QCALLTYPE ObjCMarshal_TrySetGlobalMessageSendCallback(
_In_ MessageSendFunction msgSendFunction,
_In_ ObjCMarshalNative::MessageSendFunction msgSendFunction,
_In_ void* fptr)
{
QCALL_CONTRACT;
Expand Down