Skip to content

[arm64] JIT: Fold "A * B + C" to MADD/MSUB #61037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EgorBo merged 9 commits into from
Nov 2, 2021
Merged

[arm64] JIT: Fold "A * B + C" to MADD/MSUB #61037

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
74bd53d
Fold "A * B + C" to madd
EgorBo Oct 30, 2021
eb100e1
fix arm32
EgorBo Oct 30, 2021
046cd22
guard with OptimizationEnabled
EgorBo Oct 30, 2021
c7a9da9
clean up
EgorBo Oct 31, 2021
5b1bc8f
Clean up
EgorBo Nov 1, 2021
40299d6
formatting
EgorBo Nov 1, 2021
7bf486d
Formatting
EgorBo Nov 1, 2021
8ae926f
Address feedback
EgorBo Nov 2, 2021
2591841
add assert
EgorBo Nov 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix arm32
  • Loading branch information
@EgorBo
EgorBo committed Oct 30, 2021
commit eb100e18e77c3aab42db8566f41899130eb90675
2 changes: 2 additions & 0 deletions src/coreclr/jit/lowerarmarch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1568,6 +1568,7 @@ void Lowering::ContainCheckBinary(GenTreeOp* node)
// Check and make op2 contained (if it is a containable immediate)
CheckImmedAndMakeContained(node, node->gtOp2);

#ifdef TARGET_ARM64
// Find "a * b + c" or "c + a * b" in order to emit MADD/MSUB
if (varTypeIsIntegral(node) && !node->isContained() && node->OperIs(GT_ADD) &&
(node->gtGetOp1()->OperIs(GT_MUL) || node->gtGetOp2()->OperIs(GT_MUL)))
Expand Down Expand Up @@ -1596,6 +1597,7 @@ void Lowering::ContainCheckBinary(GenTreeOp* node)
MakeSrcContained(node, mul);
}
}
#endif
}

//------------------------------------------------------------------------
Expand Down