Skip to content

Disable couple of randomly failing PerformanceCounter tests #61101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krwq merged 2 commits into from
Nov 2, 2021
Merged

Disable couple of randomly failing PerformanceCounter tests #61101

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d54a590
Disable couple of randomly failing PerformanceCounter tests
krwq Nov 2, 2021
bf4654f
fix: disabled the wrong test
krwq Nov 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: disabled the wrong test
  • Loading branch information
@krwq
krwq committed Nov 2, 2021
commit bf4654f98deff3ac44101365b212dfd7e0c53843
2 changes: 1 addition & 1 deletion src/libraries/System.Diagnostics.PerformanceCounter/tests/PerformanceCounterCategoryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,7 @@ public static void PerformanceCounterCategory_InstanceExists_Invalid()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60933", typeof(PlatformDetection), nameof(PlatformDetection.IsWindows), nameof(PlatformDetection.Is64BitProcess))]
public static void PerformanceCounterCategory_InstanceExists_Static()
{
PerformanceCounterCategory pcc = Helpers.RetryOnAllPlatforms(() => new PerformanceCounterCategory("Processor"));
Expand All @@ -281,7 +282,6 @@ public static void PerformanceCounterCategory_InstanceExists_Static()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60933", typeof(PlatformDetection), nameof(PlatformDetection.IsWindows), nameof(PlatformDetection.Is64BitProcess))]
public static void PerformanceCounterCategory_InstanceExists_StaticInvalid()
{
Assert.Throws<ArgumentNullException>(() => PerformanceCounterCategory.InstanceExists(null, "Processor", "."));
Expand Down