Skip to content

[wasm][debugger]Add hidden attribute support #61143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilonatommy merged 7 commits into from
Nov 3, 2021
Merged

[wasm][debugger]Add hidden attribute support #61143

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5e92d39
Draft of hidden attribute decorator use.
ilonatommy Nov 2, 2021
8c44fae
Removed checking custom attributes in the runtime each time the break…
ilonatommy Nov 3, 2021
5302e15
Added test for DebuggerHidden decorator.
ilonatommy Nov 3, 2021
01e5e83
By adding a line: using System.Diagnostics; IntAdd method moved down …
ilonatommy Nov 3, 2021
f021822
Reverted edition of tests not connected with HiddenAttribute.
ilonatommy Nov 3, 2021
74d27f8
Added visible method to the HiddenAttribute test.
ilonatommy Nov 3, 2021
3deab4b
Applying thaystg review suggestion.
ilonatommy Nov 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added test for DebuggerHidden decorator.
  • Loading branch information
@ilonatommy
ilonatommy committed Nov 3, 2021
commit 5302e15803e0831662649c7ceefdb2e7efb22ae4
8 changes: 8 additions & 0 deletions src/mono/wasm/debugger/DebuggerTestSuite/BreakpointTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -642,5 +642,13 @@ await EvaluateAndCheck(
}
);
}


[Fact]
public async Task DebuggerAttributeNoStopInDebuggerHidden()
{
var bp_hidden = await SetBreakpointInMethod("debugger-test.dll", "DebuggerAttribute", "HiddenMethod", 1);
Assert.Empty(bp_hidden.Value["locations"]);
}
}
}
17 changes: 17 additions & 0 deletions src/mono/wasm/debugger/tests/debugger-test/debugger-test.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

using System;
using System.Linq;
using System.Diagnostics;
public partial class Math
{ //Only append content to this class as the test suite depends on line info
public static int IntAdd(int a, int b)
Expand Down Expand Up @@ -807,3 +808,19 @@ public int Increment(int count)
return count + 1;
}
}

public class DebuggerAttribute
{
static int currentCount = 0;

[DebuggerHidden]
public static void HiddenMethod()
{
currentCount++;
}

public static void Run()
{
HiddenMethod();
}
}