Skip to content

Convert to OleDb assembly and last Cryptography DllImport to GeneratedDllImport #61184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AaronRobinsonMSFT merged 12 commits into from
Nov 6, 2021
Merged

Convert to OleDb assembly and last Cryptography DllImport to GeneratedDllImport #61184

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
bce0c11
Enable DllImport generator for all source projects.
AaronRobinsonMSFT Nov 3, 2021
a793b52
Convert OleDb to only use GeneratedDllImport.
AaronRobinsonMSFT Nov 3, 2021
8678bd9
Remove last DllImport from Cryptography assemblies.
AaronRobinsonMSFT Nov 3, 2021
8f88a54
Update source generator to distinguish between "no marshalling info"
AaronRobinsonMSFT Nov 4, 2021
a77797f
Remove unused DllImports.
AaronRobinsonMSFT Nov 4, 2021
e1fd042
Remove local CoTaskMemAlloc and CoTaskMemFree.
AaronRobinsonMSFT Nov 4, 2021
ce7a2c7
Reuse existing P/Invoke definitions.
AaronRobinsonMSFT Nov 4, 2021
2e4de7b
Replace local SysAllocStringLen with a Common define.
AaronRobinsonMSFT Nov 4, 2021
2d9da5d
Fix SysAllocStringLen.
AaronRobinsonMSFT Nov 4, 2021
9c89cb5
Merge remote-tracking branch 'upstream/main' into convert_to_generate…
AaronRobinsonMSFT Nov 4, 2021
5104c58
Update Crypto P/Invokes.
AaronRobinsonMSFT Nov 4, 2021
1881f95
Review feedback.
AaronRobinsonMSFT Nov 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove last DllImport from Cryptography assemblies.
  • Loading branch information
@AaronRobinsonMSFT
AaronRobinsonMSFT committed Nov 3, 2021
commit 8678bd934ebf2400a0baafd020a31e667665d549
4 changes: 2 additions & 2 deletions ...tography.X509Certificates/src/Internal/Cryptography/Pal.Windows/Native/Interop.crypt32.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,8 +208,8 @@ internal static SafeChainEngineHandle CertCreateCertificateChainEngine(ref CERT_
[GeneratedDllImport(Libraries.Crypt32, CharSet = CharSet.Unicode, SetLastError = true)]
private static partial bool CertCreateCertificateChainEngine(ref CERT_CHAIN_ENGINE_CONFIG pConfig, out SafeChainEngineHandle hChainEngineHandle);

[DllImport(Libraries.Crypt32)]
public static extern void CertFreeCertificateChainEngine(IntPtr hChainEngine);
[GeneratedDllImport(Libraries.Crypt32)]
public static partial void CertFreeCertificateChainEngine(IntPtr hChainEngine);

[GeneratedDllImport(Libraries.Crypt32, SetLastError = true)]
public static unsafe partial bool CertGetCertificateChain(IntPtr hChainEngine, SafeCertContextHandle pCertContext, FILETIME* pTime, SafeCertStoreHandle hStore, ref CERT_CHAIN_PARA pChainPara, CertChainFlags dwFlags, IntPtr pvReserved, out SafeX509ChainHandle ppChainContext);
Expand Down