Skip to content

JIT: don't bother with GDV for an abstract class #61191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyAyersMS merged 1 commit into from
Nov 5, 2021
Merged

JIT: don't bother with GDV for an abstract class #61191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
JIT: don't bother with GDV for an abstract class 
Fixes #61190.
  • Loading branch information
@AndyAyersMS
AndyAyersMS committed Nov 4, 2021
commit 10abab6161e366183c24e9e24212b39b0242e798
12 changes: 11 additions & 1 deletion src/coreclr/jit/importer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22230,6 +22230,17 @@ void Compiler::considerGuardedDevirtualization(
return;
}

uint32_t const likelyClassAttribs = info.compCompHnd->getClassAttribs(likelyClass);

if ((likelyClassAttribs & CORINFO_FLG_ABSTRACT) != 0)
{
// We may see an abstract likely class, if we have a stale profile.
// No point guessing for this.
//
JITDUMP("Not guessing for class; abstract (stale profile)\n");
return;
}

// Figure out which method will be called.
//
CORINFO_DEVIRTUALIZATION_INFO dvInfo;
Expand All @@ -22253,7 +22264,6 @@ void Compiler::considerGuardedDevirtualization(
// Add this as a potential candidate.
//
uint32_t const likelyMethodAttribs = info.compCompHnd->getMethodAttribs(likelyMethod);
uint32_t const likelyClassAttribs = info.compCompHnd->getClassAttribs(likelyClass);
addGuardedDevirtualizationCandidate(call, likelyMethod, likelyClass, likelyMethodAttribs, likelyClassAttribs,
likelihood);
}
Expand Down