WIP: using Jeremy's Roslyn generator to prototype the test migration process #61224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt Main method that runs all static parameterless [Fact] attributes in sequence, wrapped in a simple try-catch.
…_4 test suite to use the generator.
… basic cases of OS and runtime-specific filtering.
…ames for tests like the TypeGenerator suite). Add support for theories to handle the RunOnly tests that aren't failure cases and don't require out-of-proc execution.
Co-authored-by: Alexander Köplinger <[email protected]>
Co-authored-by: Jan Kotas <[email protected]>
…encies for package restoration
This change is based on Jeremy's POC PR; I have modified the build scripts to minimize the changes to the individual test build scripts. In the simplest case the conversion requires just replacing the Main method with a [Fact]-marked test entrypoint and removing the OutputType property from the project file. Empty OutputType property gets automatically replaced with the Library default in the SDK scripts; this is not a huge deal but I had to remove the pre-existing hack of OutputType=Library + CLRTestKind="" implying SharedLibrary. According to my search most Library projects already have the SharedLibrary CLRTestKind set, for the rest I plan to set it using a bulk project modification; I think I should be able to adapt the ILTransform analyzer for this purpose. Thanks Tomas
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
jkoritzinsky
reviewed
Nov 4, 2021
Comment on lines
+82
to
+88
| <!-- Inject the XUnit wrapper generator into test build for [Fact]-style tests --> | ||
| <ItemGroup Condition="$(IsFactStyleTest)"> | ||
| <ProjectReference Include="$(MSBuildThisFileDirectory)/Common/XUnitWrapperGenerator/XUnitWrapperGenerator.csproj" OutputItemType="Analyzer" ReferenceOutputAssembly="false" /> | ||
| </ItemGroup> | ||
|
|
||
| <Import Project="Common/XUnitWrapperGenerator/XUnitWrapperGenerator.props" Condition="$(IsFactStyleTest)" /> | ||
|
|
Member
There was a problem hiding this comment.
We can reference the generator and import the MSBuild file for all tests. The generator should be a no-op for non-Fact-style tests. If it isn't, I can make changes to the generator to fix that.
Member
Author
|
Closing as Jeremy is currently code reviewing the real change. My contribution here is very minor, involving just the subtle tweaks to |
jkoritzinsky
added a commit
to jkoritzinsky/runtime
that referenced
this pull request
Nov 16, 2021
…line discussion.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is based on Jeremy's POC PR; I have modified the build
scripts to minimize the changes to the individual test build scripts.
In the simplest case the conversion requires just replacing the Main
method with a [Fact]-marked test entrypoint and removing the
OutputType property from the project file. I have demonstrated the
transformation on the project DecimalTest.
Empty OutputType property gets automatically replaced with the Library
default in the SDK scripts; this is not a huge deal but I had to
remove the pre-existing hack of OutputType=Library + CLRTestKind=""
implying SharedLibrary. According to my search most Library projects
already have the SharedLibrary CLRTestKind set, for the rest I plan
to set it using a bulk project modification; I think I should be able
to adapt the ILTransform analyzer for this purpose.
Thanks
Tomas
Contributes to: #54512