Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
fab24e5
Using current namespace as the default place to serach for the resolv…
ilonatommy Nov 5, 2021
66b56a7
Add tests for static class, static fields and pausing in async method.
ilonatommy Nov 5, 2021
782a107
Added tests for class evaluation.
ilonatommy Nov 8, 2021
4119de3
Fixing support to the current namespace and adding tests for it
thaystg Nov 8, 2021
e275144
Merge branch 'add-static-attribute-support' of https://github.com/ilo…
ilonatommy Nov 9, 2021
ee19014
Assuing that we search within the current assembly first. Removed tes…
ilonatommy Nov 9, 2021
89bdc49
Remove a test-duplicate that was not testing static class or static f…
ilonatommy Nov 9, 2021
5ce0f57
Fixing indentation.
ilonatommy Nov 9, 2021
62d18b6
Refixing indentation.
ilonatommy Nov 9, 2021
ce177fd
Refix indentations again.
ilonatommy Nov 9, 2021
cb32402
Applied the advice about adding new blank lines.
ilonatommy Nov 10, 2021
ed2577e
Changed the current assembly check.
ilonatommy Nov 10, 2021
01f46d5
Extracting the check from the loop. One time check is enough.
ilonatommy Nov 10, 2021
d14367d
Simplifying multiple test cases into one call.
ilonatommy Nov 10, 2021
8a82380
Using local function as per review suggestion.
ilonatommy Nov 11, 2021
7f24d47
Added test that was skipped by mistake.
ilonatommy Nov 11, 2021
367c431
Added looking for the namespace in all assemblies because there is a …
ilonatommy Nov 11, 2021
55479c8
Extracting value based on the current frame, not the top of stack loc…
ilonatommy Nov 11, 2021
5f5cdf6
Test for classes evaluated from different frames.
ilonatommy Nov 11, 2021
7151177
Fixing indentation and spaces.
ilonatommy Nov 15, 2021
5fc759e
Applied review comments for values evaluation.
ilonatommy Nov 15, 2021
3661c0e
Compressed two tests into one with MemberData.
ilonatommy Nov 15, 2021
66ed5c2
Added test case of type without namespace (failing).
ilonatommy Nov 15, 2021
136f69a
Addressed Ankit advices from the review.
ilonatommy Nov 16, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Addressed Ankit advices from the review.
  • Loading branch information
ilonatommy committed Nov 16, 2021
commit 136f69a75c6b91cfe689288d4d7b74168e730738
Original file line number Diff line number Diff line change
Expand Up @@ -131,24 +131,21 @@ public async Task<JObject> TryToRunOnLoadedClasses(string varName, CancellationT
if (searchResult != null)
typeId = (int)searchResult;

async Task<Tuple<bool, int?>> TryGetTypeIdFromName(string typeName, AssemblyInfo assembly)
async Task<int?> TryGetTypeIdFromName(string typeName, AssemblyInfo assembly)
{
int typeId;
var type = assembly.GetTypeByName(typeName);
if (type == null)
return new Tuple<bool, int?>(false, null);

typeId = await sdbHelper.GetTypeIdFromToken(sessionId, assembly.DebugId, type.Token, token);
return new Tuple<bool, int?>(true, typeId); ;
return null;
return await sdbHelper.GetTypeIdFromToken(sessionId, assembly.DebugId, type.Token, token);
}

async Task<int?> TryFindNameInAssembly(List<AssemblyInfo> assemblies, string name)
{
foreach (var asm in assemblies)
{
var searchResult = await TryGetTypeIdFromName(name, asm);
if (searchResult.Item1)
return searchResult.Item2;
var typeId = await TryGetTypeIdFromName(name, asm);
if (typeId != null)
return typeId;
}
return null;
}
Expand Down