Skip to content

[arm64] JIT: Enable CSE/hoisting for "arrayBase + elementOffset" #61293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EgorBo merged 22 commits into from
Nov 10, 2021
Merged

[arm64] JIT: Enable CSE/hoisting for "arrayBase + elementOffset" #61293

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
379896a
Lower GT_INDEX into "(base + elemOffsetCns) + index" on arm arch
EgorBo Nov 6, 2021
1353a68
change assert
EgorBo Nov 6, 2021
6264ee1
fix build
EgorBo Nov 6, 2021
1bdd5dd
Clean up
EgorBo Nov 7, 2021
13d45a5
Merge branch 'main' of https://github.com/dotnet/runtime into arm64-h…
EgorBo Nov 7, 2021
1802625
Experimental: LEA(BFIZ)
EgorBo Nov 7, 2021
76ce581
fix build
EgorBo Nov 7, 2021
f228b81
fix build
EgorBo Nov 7, 2021
ff1a219
test
EgorBo Nov 7, 2021
8ccc15e
Clean up
EgorBo Nov 8, 2021
fbc7ffe
Clean up
EgorBo Nov 8, 2021
a60961e
Update lower.cpp
EgorBo Nov 8, 2021
17b08f3
Clean up
EgorBo Nov 8, 2021
1967ccf
Oops
EgorBo Nov 8, 2021
6cdeaca
Add comments
EgorBo Nov 8, 2021
9e0d14e
Merge branch 'main' of https://github.com/dotnet/runtime into arm64-h…
EgorBo Nov 8, 2021
c6fd484
Update src/coreclr/jit/lower.cpp
EgorBo Nov 8, 2021
36dd9f8
Address feedback
EgorBo Nov 8, 2021
fc538af
Merge branch 'arm64-hoist-addr' of https://github.com/EgorBo/runtime-…
EgorBo Nov 8, 2021
eb2b57c
formatting
EgorBo Nov 8, 2021
32f33b2
Address feedback
EgorBo Nov 9, 2021
ed73972
Reduce number of regressions
EgorBo Nov 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update src/coreclr/jit/lower.cpp 
Co-authored-by: SingleAccretion <[email protected]>
  • Loading branch information
@EgorBo @SingleAccretion
EgorBo and SingleAccretion authored Nov 8, 2021
commit c6fd48469c54bc31c7c550a9a3e581df6726b52d
2 changes: 1 addition & 1 deletion src/coreclr/jit/lower.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5035,7 +5035,7 @@ bool Lowering::TryCreateAddrMode(GenTree* addr, bool isContainable, var_types ta

#ifdef TARGET_ARM64
// Check if we can "contain" LEA(BFIZ) in order to extend 32bit index to 64bit as part of load/store.
if (index != nullptr && index->OperIs(GT_BFIZ) && index->gtGetOp1()->OperIs(GT_CAST) &&
if ((index != nullptr) && index->OperIs(GT_BFIZ) && index->gtGetOp1()->OperIs(GT_CAST) &&
index->gtGetOp2()->IsCnsIntOrI() && varTypeIsIntegral(targetType))
{
// BFIZ node is a binary op where op1 is GT_CAST and op2 is GT_CNS_INT
Expand Down