Skip to content

[wasm][debugger] Stepping into hidden function. #61312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilonatommy merged 14 commits into from
Nov 26, 2021
+144 −6
Merged

[wasm][debugger] Stepping into hidden function. #61312

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
5cc4aae
Add test for ignoring stepping into hidden function.
ilonatommy Nov 8, 2021
7ddab49
Merge branch 'dotnet:main' into debugger-hidden-attribute
ilonatommy Nov 19, 2021
83036e7
Corrected test to match Console App behaviour.
ilonatommy Nov 19, 2021
dbdf6ea
Corrected test logic.
ilonatommy Nov 22, 2021
faf1e3c
Applied Thays's fix so that step into would work as step over in a hi…
ilonatommy Nov 22, 2021
4b08a7d
Revert debugging changes.
ilonatommy Nov 22, 2021
064b4e2
Test for Debugger.Break().
ilonatommy Nov 22, 2021
c68505a
Col fix + checing the location after command execution.
ilonatommy Nov 22, 2021
a64cdee
Correct value of VisibleMethod entry line.
ilonatommy Nov 22, 2021
809c443
Move the breakpoint to the line 846.
ilonatommy Nov 22, 2021
02cbfd3
Create tests that match behaviour of Console App.
ilonatommy Nov 23, 2021
3c6a5c2
Draft of Debugger.Break behaviour correction.
ilonatommy Nov 23, 2021
3dc2a56
Draft: 2 pauses on hidden method with Debugger.Break inside.
ilonatommy Nov 23, 2021
3b1b047
Changed required behaviour to 2 pauses on the hidden method call.
ilonatommy Nov 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Changed required behaviour to 2 pauses on the hidden method call.
  • Loading branch information
@ilonatommy
ilonatommy committed Nov 23, 2021
commit 3b1b047098b5bd25e3309e214c1b98d6e0e9d407
19 changes: 2 additions & 17 deletions src/mono/wasm/debugger/DebuggerTestSuite/SteppingTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -989,16 +989,9 @@ await EvaluateAndCheck(

var step_into2 = await SendCommandAndCheck(null, $"Debugger.stepInto", null, -1, -1, null);

Assert.Equal(
pause_location.Value["locations"][0]["lineNumber"].Value<int>(),
step_into2["callFrames"][0]["location"]["lineNumber"].Value<int>()
);

var step_into3 = await SendCommandAndCheck(null, $"Debugger.stepInto", null, -1, -1, null);

Assert.Equal(
pause_location.Value["locations"][0]["lineNumber"].Value<int>() + 1,
step_into3["callFrames"][0]["location"]["lineNumber"].Value<int>()
step_into2["callFrames"][0]["location"]["lineNumber"].Value<int>()
);

}
Expand All @@ -1022,18 +1015,10 @@ await EvaluateAndCheck(

var step_over2 = await SendCommandAndCheck(null, $"Debugger.stepOver", null, -1, -1, null);

Assert.Equal(
pause_location.Value["locations"][0]["lineNumber"].Value<int>(),
step_over2["callFrames"][0]["location"]["lineNumber"].Value<int>()
);

var step_over3 = await SendCommandAndCheck(null, $"Debugger.stepOver", null, -1, -1, null);

Assert.Equal(
pause_location.Value["locations"][0]["lineNumber"].Value<int>() + 1,
step_over3["callFrames"][0]["location"]["lineNumber"].Value<int>()
step_over2["callFrames"][0]["location"]["lineNumber"].Value<int>()
);

}
}
}