Skip to content

Change WASM direct heap access to use helper functions #61355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kg merged 6 commits into from
Nov 10, 2021
Merged

Change WASM direct heap access to use helper functions #61355

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a5666f9
Refactor direct heap access to use helper functions
kg Nov 9, 2021
5712dc0
Expose memory accessors via INTERNAL
kg Nov 9, 2021
91e4622
Be more specific
kg Nov 9, 2021
026c0e5
Add comment explaining how i64 accesses work historically since it's …
kg Nov 9, 2021
7c94f75
Address PR feedback
kg Nov 10, 2021
577248b
Add type info
kg Nov 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Expose memory accessors via INTERNAL
  • Loading branch information
@kg
kg committed Nov 9, 2021
commit 5712dc0bc99d4a88bf3e64faa05c730df8ec938c
3 changes: 3 additions & 0 deletions src/mono/wasm/runtime/exports.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ import { mono_wasm_release_cs_owned_object } from "./gc-handles";
import { mono_wasm_web_socket_open, mono_wasm_web_socket_send, mono_wasm_web_socket_receive, mono_wasm_web_socket_close, mono_wasm_web_socket_abort } from "./web-socket";
import cwraps from "./cwraps";
import { ArgsMarshalString } from "./method-binding";
import { __AllAccessors__ } from "./memory";

export const MONO: MONO = <any>{
// current "public" MONO API
Expand Down Expand Up @@ -252,6 +253,8 @@ export const INTERNAL: any = {
mono_wasm_raise_debug_event,
mono_wasm_runtime_is_ready: runtimeHelpers.mono_wasm_runtime_is_ready,
};
// Expose all the get/set methods via INTERNAL
Object.assign(INTERNAL, __AllAccessors__);

// this represents visibility in the javascript
// like https://github.com/dotnet/aspnetcore/blob/main/src/Components/Web.JS/src/Platform/Mono/MonoTypes.ts
Expand Down