Skip to content

Provide locations for src-gen diagnostic output #61430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
layomia merged 3 commits into from
Nov 16, 2021
Merged

Provide locations for src-gen diagnostic output #61430

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4eadba4
Provide locations for src-gen diagnostic output
layomia Nov 10, 2021
97452f7
Fix tests and address feedback
layomia Nov 15, 2021
29d2da4
Add defensive check for context type location
layomia Nov 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add defensive check for context type location
  • Loading branch information
@layomia
layomia committed Nov 15, 2021
commit 29d2da4f41ee64d9b546319c5d17e7adee841170
2 changes: 1 addition & 1 deletion src/libraries/System.Text.Json/gen/JsonSourceGenerator.Parser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ public Parser(Compilation compilation, in JsonSourceGenerationContext sourceGene
INamedTypeSymbol contextTypeSymbol = (INamedTypeSymbol)compilationSemanticModel.GetDeclaredSymbol(classDeclarationSyntax);
Debug.Assert(contextTypeSymbol != null);

Location contextLocation = contextTypeSymbol.Locations[0];
Location contextLocation = contextTypeSymbol.Locations.Length > 0 ? contextTypeSymbol.Locations[0] : Location.None;

if (!TryGetClassDeclarationList(contextTypeSymbol, out List<string> classDeclarationList))
{
Expand Down