Skip to content

[wasm][debugger] Improvement of memory consumption while Evaluating Expressions #61470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thaystg merged 15 commits into from
Nov 16, 2021
Merged

[wasm][debugger] Improvement of memory consumption while Evaluating Expressions #61470

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
72ad108
Fix memory consumption.
thaystg Nov 11, 2021
d65373b
Merge branch 'dotnet:main' into thays_fix_memory_evaluation
thaystg Nov 11, 2021
9755954
Fix debugger-tests
thaystg Nov 11, 2021
3e832bf
Fix compilation.
thaystg Nov 11, 2021
498e2c1
Addressing @lewing PR.
thaystg Nov 11, 2021
d505d40
Address @lewing comment
thaystg Nov 11, 2021
69ad647
Addressing @radical comment.
thaystg Nov 11, 2021
d8e3e57
Addressing comments.
thaystg Nov 11, 2021
0128938
Addressing @radical comments.
thaystg Nov 11, 2021
194ee4f
missing return.
thaystg Nov 11, 2021
36e7e56
Addressing @radical comments
thaystg Nov 11, 2021
0a686ec
Adding test case
thaystg Nov 11, 2021
97b98ce
Fixing tests.
thaystg Nov 11, 2021
bd552fd
Adding another test case. Thanks @lewing.
thaystg Nov 11, 2021
351f897
Reuse the script.
thaystg Nov 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix compilation.
  • Loading branch information
@thaystg
thaystg committed Nov 11, 2021
commit 3e832bf76bed8c0d272d3cfeb9284acc84353b1f
2 changes: 1 addition & 1 deletion src/mono/wasm/debugger/BrowserDebugProxy/EvaluateExpression.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ internal static async Task<JObject> CompileAndRunTheExpression(string expression
cancellationToken: token);
return JObject.FromObject(ConvertCSharpToJSType(task.Result, task.Result.GetType()));
}
catch (Exception e)
catch (Exception)
{
throw new ReturnAsErrorException($"Cannot evaluate '{expression}'.", "CompilationError");
}
Expand Down