Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
62 commits
Select commit Hold shift + click to select a range
d1fe014
Modify existing tests
simonrozsival Nov 12, 2021
17c6eec
Enable process start and kill on MacCatalyst
simonrozsival Nov 12, 2021
2d76ff3
Typo
simonrozsival Nov 12, 2021
0d55868
Temporarily enable ProcessTests for MacCatalyst
simonrozsival Nov 15, 2021
b0a1f9a
Temporarily enable ProcessTests for MacCatalyst - attempt 2
simonrozsival Nov 15, 2021
09a520a
Allow running Mac Catalyst builds in App Sandbox
simonrozsival Nov 15, 2021
83fa170
Allow enabling app sandbox for the other Mac Catalyst sample
simonrozsival Nov 15, 2021
9409c8d
Add missing parameter to XCode project generator
simonrozsival Nov 15, 2021
6b25194
Remove unnecessary MacCatalyst detection
simonrozsival Nov 18, 2021
f065754
Enable App Sandbox for Mac Catalyst tests
simonrozsival Nov 18, 2021
aa5bf93
Create a separate test branch for App Sandbox
simonrozsival Nov 22, 2021
320cbe7
Remove the restriction to enable app sandbox just for Mac Catalyst apps
simonrozsival Nov 22, 2021
15108a7
Do not throw PNSE for Mac Catalyst
simonrozsival Nov 22, 2021
2525e79
Clean-up platform-specific conditions
simonrozsival Nov 22, 2021
1a57e88
Build correct Process implementation for MacCatalyst
simonrozsival Nov 23, 2021
da46eca
Merge branch 'main' into simonrozsival/61295-support-process-start-on…
simonrozsival Nov 23, 2021
fc63a37
Try to get more information from CI for further investigation of the …
simonrozsival Nov 24, 2021
f9e4b67
Revert "Try to get more information from CI for further investigation…
simonrozsival Nov 24, 2021
9e4443b
Add MacCatalyst target framework for System.Diagnostics.Process
simonrozsival Nov 24, 2021
20840a5
Merge branch 'main' of https://github.com/dotnet/runtime into simonro…
simonrozsival Nov 24, 2021
5be64c6
Add supported platform annotations for Mac Catalyst
simonrozsival Nov 24, 2021
c620358
Fix annotations
simonrozsival Nov 24, 2021
f027660
Remove incorrectly placed attributes
simonrozsival Nov 24, 2021
ed8e9d8
Update attributes including the reference file
simonrozsival Nov 24, 2021
7119d72
Change platform attributes
simonrozsival Nov 25, 2021
abbe224
Generate app.entitlements in the BuildAppleAppBundles test build target
simonrozsival Nov 25, 2021
ace7d76
Revert "Generate app.entitlements in the BuildAppleAppBundles test bu…
simonrozsival Nov 26, 2021
b805ba2
Enable AppSandbox when generating CMakeLists.txt for libraries tests
simonrozsival Nov 26, 2021
8130507
Try implementing a workaround for app sandbox mode
simonrozsival Nov 29, 2021
9b55d57
Fix app sandbox detection bug
simonrozsival Nov 29, 2021
7a3dc2b
Add explanation comment
simonrozsival Nov 30, 2021
02d4991
Enable more tests for MacCatalyst
simonrozsival Nov 30, 2021
6e18a52
Merge branch 'main' of https://github.com/dotnet/runtime into simonro…
simonrozsival Nov 30, 2021
3273fac
Add apple app builder input validation
simonrozsival Nov 30, 2021
d37da5c
Add Mac Catalyst w/ App Sandbox enabled to runtime-manual test pipeline
simonrozsival Nov 30, 2021
1dad157
Enable networking in App Sandbox mode
simonrozsival Nov 30, 2021
5c82f7c
Skip test which won't work on Mac Catalyst
simonrozsival Nov 30, 2021
6b52a30
Skip some tests in app sandbox mode
simonrozsival Nov 30, 2021
77dcb93
Update src/tasks/AppleAppBuilder/AppleAppBuilder.cs
simonrozsival Dec 1, 2021
38bce10
Add a clarification comment for a networking entitlement
simonrozsival Dec 1, 2021
93944c0
Simplify supported platform condition
simonrozsival Dec 1, 2021
80d2984
Merge branch 'simonrozsival/61295-support-process-start-on-mac-cataly…
simonrozsival Dec 1, 2021
02d370c
Remove temporarily enabled test
simonrozsival Dec 1, 2021
4c8d12b
Remove unnecessary attributes
simonrozsival Dec 1, 2021
f2b752b
Replace checking env variable with checking errno in libproc
simonrozsival Dec 1, 2021
ee6dcec
Update docs
simonrozsival Dec 2, 2021
0db6178
Remove unnecessary changes
simonrozsival Dec 2, 2021
dc72f0f
Temporarily enable running System.Diagnostics.Process.Tests for this PR
simonrozsival Dec 3, 2021
efc863c
Revert "Temporarily enable running System.Diagnostics.Process.Tests f…
simonrozsival Dec 3, 2021
dcf8e92
Fix job suffix in runtime-manual
simonrozsival Dec 6, 2021
704e9fa
Remove attributes
simonrozsival Dec 6, 2021
52bfaae
Revert "Remove attributes"
simonrozsival Dec 6, 2021
b3cc2ac
Try changing the order of attributes to please CI
simonrozsival Dec 6, 2021
a2ad032
Update ApiCompat baseline
simonrozsival Dec 6, 2021
be72a3d
ApiCompat step 1: remove all attributes for MaxWorkingSet setter
simonrozsival Dec 7, 2021
9d5e5a9
Revert "Update ApiCompat baseline"
simonrozsival Dec 7, 2021
32f2c6b
Revert "ApiCompat step 1: remove all attributes for MaxWorkingSet set…
simonrozsival Dec 7, 2021
85fa8cf
Update ApiCompat baseline
simonrozsival Dec 7, 2021
e3bf3dc
Merge branch 'main' of github.com:simonrozsival/runtime into simonroz…
simonrozsival Dec 7, 2021
8ac8661
Update ApiCompat baseline after pulling upstream main
simonrozsival Dec 7, 2021
df0ce4e
Merge branch 'main' into simonrozsival/61295-support-process-start-on…
simonrozsival Dec 7, 2021
8206e28
Remove trailing whitespace
simonrozsival Dec 7, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clean-up platform-specific conditions
  • Loading branch information
simonrozsival committed Nov 22, 2021
commit 2525e79839c629aa2111a35499478a43c3eb5022
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public static Process Start(string fileName, string arguments, string userName,
[UnsupportedOSPlatform("tvos")]
public void Kill()
{
if ((OperatingSystem.IsIOS() && !OperatingSystem.IsMacCatalyst()) || OperatingSystem.IsTvOS())
if (!PlatformSupportsProcessStartAndKill)
{
throw new PlatformNotSupportedException();
}
Expand Down Expand Up @@ -372,7 +372,7 @@ private SafeProcessHandle GetProcessHandle()
/// <param name="startInfo">The start info with which to start the process.</param>
private bool StartCore(ProcessStartInfo startInfo)
{
if ((OperatingSystem.IsIOS() && !OperatingSystem.IsMacCatalyst()) || OperatingSystem.IsTvOS())
if (!PlatformSupportsProcessStartAndKill)
{
throw new PlatformNotSupportedException();
}
Expand Down Expand Up @@ -1105,5 +1105,8 @@ private static int OnSigChild(int reapAll, int configureConsole)
s_processStartLock.ExitWriteLock();
}
}

private static bool PlatformSupportsProcessStartAndKill
=> (!OperatingSystem.IsIOS() || OperatingSystem.IsMacCatalyst()) && !OperatingSystem.IsTvOS();
}
}