Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Delete regArgList
Unused.
  • Loading branch information
SingleAccretion committed Nov 12, 2021
commit caa65f3eafc3fffcbbeff69e4d2360192324a28f
1 change: 0 additions & 1 deletion src/coreclr/jit/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,6 @@ if (CLR_CMAKE_TARGET_WIN32)
regalloc.h
register_arg_convention.h
register.h
reglist.h
regset.h
sideeffects.h
simd.h
Expand Down
1 change: 0 additions & 1 deletion src/coreclr/jit/compiler.h
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
#include "jitexpandarray.h"
#include "tinyarray.h"
#include "valuenum.h"
#include "reglist.h"
#include "jittelemetry.h"
#include "namedintrinsiclist.h"
#ifdef LATE_DISASM
Expand Down
35 changes: 1 addition & 34 deletions src/coreclr/jit/gentree.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -8235,11 +8235,6 @@ GenTreeCall* Compiler::gtCloneExprCallHelper(GenTreeCall* tree,
argsTail = &((*argsTail)->NextRef());
}

#if !FEATURE_FIXED_OUT_ARGS
copy->regArgList = tree->regArgList;
copy->regArgListCount = tree->regArgListCount;
#endif

// The call sig comes from the EE and doesn't change throughout the compilation process, meaning
// we only really need one physical copy of it. Therefore a shallow pointer copy will suffice.
// (Note that this still holds even if the tree we are cloning was created by an inlinee compiler,
Expand Down Expand Up @@ -8757,28 +8752,6 @@ GenTree* Compiler::gtGetThisArg(GenTreeCall* call)
// Assert if we used DEBUG_DESTROY_NODE.
assert(result->gtOper != GT_COUNT);

#if !FEATURE_FIXED_OUT_ARGS && defined(DEBUG)
// Check that call->fgArgInfo used in gtArgEntryByArgNum was not
// left outdated by assertion propogation updates.
// There is no information about registers of late args for platforms
// with FEATURE_FIXED_OUT_ARGS that is why this debug check is under
// !FEATURE_FIXED_OUT_ARGS.
regNumber thisReg = REG_ARG_0;
regList list = call->regArgList;
int index = 0;
for (GenTreeCall::Use& use : call->LateArgs())
{
assert(index < call->regArgListCount);
regNumber curArgReg = list[index];
if (curArgReg == thisReg)
{
assert(result == use.GetNode());
}

index++;
}
#endif // !FEATURE_FIXED_OUT_ARGS && defined(DEBUG)

return result;
}

Expand Down Expand Up @@ -12050,9 +12023,6 @@ void Compiler::gtDispTree(GenTree* tree,
(call->gtControlExpr == lastChild) ? IIArcBottom : IIArc, "control expr", topOnly);
}

#if !FEATURE_FIXED_OUT_ARGS
regList list = call->regArgList;
#endif
int lateArgIndex = 0;
for (GenTreeCall::Use& use : call->LateArgs())
{
Expand Down Expand Up @@ -12231,10 +12201,7 @@ void Compiler::gtGetLateArgMsg(GenTreeCall* call, GenTree* argx, int lateArgInde
assert(curArgTabEntry);
regNumber argReg = curArgTabEntry->GetRegNum();

#if !FEATURE_FIXED_OUT_ARGS
assert(lateArgIndex < call->regArgListCount);
assert(argReg == call->regArgList[lateArgIndex]);
#else
#if FEATURE_FIXED_OUT_ARGS
if (argReg == REG_STK)
{
sprintf_s(bufp, bufLength, "arg%d in out+%02x%c", curArgTabEntry->argNum, curArgTabEntry->GetByteOffset(), 0);
Expand Down
6 changes: 0 additions & 6 deletions src/coreclr/jit/gentree.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
#include "vartype.h" // For "var_types"
#include "target.h" // For "regNumber"
#include "ssaconfig.h" // For "SsaConfig::RESERVED_SSA_NUM"
#include "reglist.h"
#include "valuenumtype.h"
#include "jitstd.h"
#include "jithashtable.h"
Expand Down Expand Up @@ -4244,11 +4243,6 @@ struct GenTreeCall final : public GenTree
return UseList(gtCallLateArgs);
}

#if !FEATURE_FIXED_OUT_ARGS
int regArgListCount;
regList regArgList;
#endif

#ifdef DEBUG
// Used to register callsites with the EE
CORINFO_SIG_INFO* callSig;
Expand Down
21 changes: 0 additions & 21 deletions src/coreclr/jit/morph.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1712,27 +1712,6 @@ void fgArgInfo::SortArgs()
assert(begTab == (endTab + 1));
assert(argsRemaining == 0);

#if !FEATURE_FIXED_OUT_ARGS
// Finally build the regArgList
//
callTree->AsCall()->regArgList = NULL;
callTree->AsCall()->regArgListCount = regCount;

unsigned regInx = 0;
for (curInx = 0; curInx < argCount; curInx++)
{
fgArgTabEntry* curArgTabEntry = argTable[curInx];

if (curArgTabEntry->GetRegNum() != REG_STK)
{
// Encode the argument register in the register mask
//
callTree->AsCall()->regArgList[regInx] = curArgTabEntry->GetRegNum();
regInx++;
}
}
#endif // !FEATURE_FIXED_OUT_ARGS

argsSorted = true;
}

Expand Down
17 changes: 0 additions & 17 deletions src/coreclr/jit/reglist.h

This file was deleted.