Skip to content

[wasm] renames and cleanup before modularization #61596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pavelsavara merged 10 commits into from
Nov 17, 2021
Merged

[wasm] renames and cleanup before modularization #61596

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
304a8b6
- no imports from outer scope
pavelsavara Nov 15, 2021
9b14f6c
feedback from @kg and @maraf
pavelsavara Nov 16, 2021
ba2bd5d
observe exit behavior
pavelsavara Nov 16, 2021
10a7ff0
early console redirect
pavelsavara Nov 16, 2021
c9ecc18
move log about exit
pavelsavara Nov 16, 2021
d458eda
delayed exit
pavelsavara Nov 16, 2021
367aca3
fix build
pavelsavara Nov 16, 2021
5a1cb89
Merge branch 'main' into wasm_modularization8
pavelsavara Nov 16, 2021
9a7ca35
fix
pavelsavara Nov 16, 2021
70764a2
defensive exit
pavelsavara Nov 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
move log about exit
  • Loading branch information
@pavelsavara
pavelsavara committed Nov 16, 2021
commit c9ecc18390f4308d027a0286cd6f27b9513a3ea0
3 changes: 2 additions & 1 deletion src/mono/wasm/test-main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,14 +230,15 @@ const App = {
globalThis.App = App; // Necessary as System.Runtime.InteropServices.JavaScript.Tests.MarshalTests (among others) call the App.call_test_method directly

function set_exit_code(exit_code, reason) {
originalConsole.log(`Exit called with ${exit_code} when isXUnitDoneCheck=${isXUnitDoneCheck} from ${(new Error()).stack}.`)
if (reason) {
console.error(reason.toString());
if (reason.stack) {
console.error(reason.stack);
}
}
if (is_browser) {
originalConsole.log(`Exit called with ${exit_code} when isXUnitDoneCheck=${isXUnitDoneCheck} from ${(new Error()).stack}.`)

// Notify the selenium script
Module.exit_code = exit_code;

Expand Down