Skip to content

[iOS] Follow up changes for 61590 #61670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaximLipnin merged 6 commits into from
Nov 18, 2021
Merged

[iOS] Follow up changes for 61590 #61670

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7ce1772
Mark some System.Diagnostics.Process APIs with the UnsupportedOSPlatf…
MaximLipnin Nov 16, 2021
026bb2a
Skip some System.Diagnostics.Process tests as liibproc is not support…
MaximLipnin Nov 16, 2021
6320e76
Add UnsupportedOSPlatform annotations to other partial implementation…
MaximLipnin Nov 16, 2021
13ccc32
Skip a couple more S.D.P tests
MaximLipnin Nov 17, 2021
702b903
Use a pragma to fix the CS0649 warning about unused fields
MaximLipnin Nov 17, 2021
1a10a70
Remove NoWarn
MaximLipnin Nov 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use a pragma to fix the CS0649 warning about unused fields
  • Loading branch information
@MaximLipnin
MaximLipnin committed Nov 17, 2021
commit 702b903f134b39fb112dcfa41a4ab046900d74cf
2 changes: 1 addition & 1 deletion src/libraries/System.Diagnostics.Process/src/System.Diagnostics.Process.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<TargetFrameworks>$(NetCoreAppCurrent)-windows;$(NetCoreAppCurrent)-FreeBSD;$(NetCoreAppCurrent)-Linux;$(NetCoreAppCurrent);$(NetCoreAppCurrent)-OSX;$(NetCoreAppCurrent)-iOS;$(NetCoreAppCurrent)-tvOS</TargetFrameworks>
<Nullable>enable</Nullable>
<!-- Suppress unused field warnings when using PlatformNotSupportedException stubs -->
<NoWarn Condition=" '$(TargetsFreeBSD)' == 'true' or '$(TargetsUnknownUnix)' == 'true' or '$(TargetsiOS)' == 'true' or '$(TargetstvOS)' == 'true' ">$(NoWarn);0649</NoWarn>
<NoWarn Condition=" '$(TargetsFreeBSD)' == 'true' or '$(TargetsUnknownUnix)' == 'true'">$(NoWarn);0649</NoWarn>
</PropertyGroup>
<PropertyGroup>
<GeneratePlatformNotSupportedAssemblyMessage Condition="'$(TargetsAnyOS)' == 'true'">SR.Process_PlatformNotSupported</GeneratePlatformNotSupportedAssemblyMessage>
Expand Down
2 changes: 2 additions & 0 deletions src/libraries/System.Diagnostics.Process/src/System/Diagnostics/ThreadInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,14 @@ namespace System.Diagnostics
/// <internalonly/>
internal sealed class ThreadInfo
{
#pragma warning disable CS0649 // The fields are unused on iOS/tvOS as the respective managed logic (mostly around libproc) is excluded.
internal ulong _threadId;
internal int _processId;
internal int _basePriority;
internal int _currentPriority;
internal IntPtr _startAddress;
internal ThreadState _threadState;
internal ThreadWaitReason _threadWaitReason;
#pragma warning restore CS0649
}
}