Skip to content

[System.Text.Json] Move inline throw statements to ThrowHelper #61746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eiriktsarpalis merged 5 commits into from
Nov 23, 2021
Merged

[System.Text.Json] Move inline throw statements to ThrowHelper #61746

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f66471d
Replace occurrences of inlined throws with ThrowHelper calls
eiriktsarpalis Nov 17, 2021
d32b1e3
remove NoInlining from ThrowHelpers.Throw* methods
eiriktsarpalis Nov 18, 2021
8c334b7
address feedback
eiriktsarpalis Nov 18, 2021
1b49f3d
remove NoInlining attribute from local throw method
eiriktsarpalis Nov 18, 2021
791ec4e
Incorporate changes from #61608
eiriktsarpalis Nov 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove NoInlining from ThrowHelpers.Throw* methods
  • Loading branch information
@eiriktsarpalis
eiriktsarpalis committed Nov 23, 2021
commit d32b1e3350a330e89084f89babd64a0395a45f31
8 changes: 0 additions & 8 deletions src/libraries/System.Text.Json/src/System/Text/Json/ThrowHelper.Node.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,56 +9,48 @@ namespace System.Text.Json
internal static partial class ThrowHelper
{
[DoesNotReturn]
[MethodImpl(MethodImplOptions.NoInlining)]
public static void ThrowArgumentException_NodeValueNotAllowed(string paramName)
{
throw new ArgumentException(SR.NodeValueNotAllowed, paramName);
}

[DoesNotReturn]
[MethodImpl(MethodImplOptions.NoInlining)]
public static void ThrowArgumentException_NodeArrayTooSmall(string paramName)
{
throw new ArgumentException(SR.NodeArrayTooSmall, paramName);
}

[DoesNotReturn]
[MethodImpl(MethodImplOptions.NoInlining)]
public static void ThrowArgumentOutOfRangeException_NodeArrayIndexNegative(string paramName)
{
throw new ArgumentOutOfRangeException(paramName, SR.NodeArrayIndexNegative);
}

[DoesNotReturn]
[MethodImpl(MethodImplOptions.NoInlining)]
public static void ThrowArgumentException_DuplicateKey(string propertyName)
{
throw new ArgumentException(SR.NodeDuplicateKey, propertyName);
}

[DoesNotReturn]
[MethodImpl(MethodImplOptions.NoInlining)]
public static void ThrowInvalidOperationException_NodeAlreadyHasParent()
{
throw new InvalidOperationException(SR.NodeAlreadyHasParent);
}

[DoesNotReturn]
[MethodImpl(MethodImplOptions.NoInlining)]
public static void ThrowInvalidOperationException_NodeCycleDetected()
{
throw new InvalidOperationException(SR.NodeCycleDetected);
}

[DoesNotReturn]
[MethodImpl(MethodImplOptions.NoInlining)]
public static void ThrowInvalidOperationException_NodeElementCannotBeObjectOrArray()
{
throw new InvalidOperationException(SR.NodeElementCannotBeObjectOrArray);
}

[DoesNotReturn]
[MethodImpl(MethodImplOptions.NoInlining)]
public static void ThrowNotSupportedException_NodeCollectionIsReadOnly()
{
throw GetNotSupportedException_NodeCollectionIsReadOnly();
Expand Down
Loading