Skip to content

Introduce non-shipped System.Runtime.Internal assembly #61754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jkoritzinsky wants to merge 6 commits into from
Closed

Introduce non-shipped System.Runtime.Internal assembly #61754

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0836ae1
Introduce non-shipped System.Runtime.Internal assembly
jkoritzinsky Nov 17, 2021
4f4ee14
Don't build CoreLib in the build-test-job as nothing should need it a…
jkoritzinsky Nov 17, 2021
64d30cf
Update src/tests/Interop/COM/Activator/Program.cs
jkoritzinsky Nov 17, 2021
f233d76
Explicitly block packing Ssytem.Runtime.Internal into a NuGet package…
jkoritzinsky Nov 17, 2021
1cd5be6
Merge branch 'system.runtime.internal' of github.com:jkoritzinsky/run…
jkoritzinsky Nov 17, 2021
4a0831b
Merge branch 'main' into system.runtime.internal
jkoritzinsky Nov 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/System.Runtime.Internal/Directory.Build.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project>

<Target Name="DisallowPacking" BeforeTargets="Pack">
<Target Name="DisallowPacking" BeforeTargets="Pack" Condition="'$(IsPackable)' == 'true'">
<Error Text="System.Runtime.Internal should never be shipped outside of this repository so building a NuGet package for it is blocked as there is no use case for a NuGet package of an entirely repo-local assembly." />
</Target>

Expand Down
2 changes: 1 addition & 1 deletion src/tests/Interop/COM/Activator/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ namespace Activator
[ComVisible(false)]
[Guid("00000001-0000-0000-C000-000000000046")]
[InterfaceType(ComInterfaceType.InterfaceIsIUnknown)]
public interface IClassFactory
interface IClassFactory
{
void CreateInstance(
[MarshalAs(UnmanagedType.Interface)] object pUnkOuter,
Expand Down