Brand release/6.0-maui branch appropriately

[directhex]

Update branch used for maui previews and get it building

[ghost]

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

[mmitche]

Aside from the StabilizePackageVersions issue, I think this is correct.

[safern]

You also want to remove all instances of ServicingVersion and GeneratePackageOnBuild

runtime/src/libraries/System.Text.Json/src/System.Text.Json.csproj

Line 13 in e9036b0

<ServicingVersion>1</ServicingVersion>

those should be added until you want to service that specific package.

[safern]

GeneratePackageOnBuild

Well the transport packages should keep that if you need to service those.

[directhex]

Failing because _PackageVersion is empty but I don't see why - it should be populated by $(PackageVersion) in https://github.com/directhex/runtime/blob/brand-maui-branch/src/libraries/workloads-testing.targets#L5 as far as I can see, and PackageVersion is not empty as I read the binlogs

[steveisok]

Failing because _PackageVersion is empty but I don't see why - it should be populated by $(PackageVersion) in https://github.com/directhex/runtime/blob/brand-maui-branch/src/libraries/workloads-testing.targets#L5 as far as I can see, and PackageVersion is not empty as I read the binlogs

@radical can you provide any insight?

[directhex]

Seems more likely related to changes by @mmitche to the version handling in that file

[safern]

I see what's going on and I hit this on main when porting these changes to main. PackageVersion is not set at this point when this property group is evaluated, so that it is why its value is empty. In order to fix this, we need to move the PropertyGroup that sets _PackageVersion inside the target, so that the property value is assigned when the target is executed and therefore PackageVersion will already be evaluated and assigned. See: https://github.com/dotnet/runtime/blob/main/eng/testing/workloads-testing.targets#L96-L97

[directhex]

@safern @mmitche any objections? We're green