Skip to content

Mono hot reload reorg and beginning (disabled) add method support #61853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lambdageek merged 20 commits into from
Nov 30, 2021
Merged

Mono hot reload reorg and beginning (disabled) add method support #61853

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
36d9693
checkpoint: allow adding methods to existing classes.
lambdageek Jun 8, 2021
0c4aa74
fixme in loader
lambdageek Jun 22, 2021
c68b895
[metadata] Add mono_metadata_table_num_rows
lambdageek Jul 13, 2021
d0b7d77
add table to ptr table helper
lambdageek Jul 13, 2021
25e2fb8
Param attr lookups for deltas can have param_index == 0
lambdageek Jul 13, 2021
099edb5
WIP: start adding support for parameter additions.
lambdageek Jul 13, 2021
6cbee0b
WIP: add MethodDef -> TypeDef lookup
lambdageek Jul 15, 2021
8cfb9fb
Add hot reload test for lambda capturing this
lambdageek Jul 15, 2021
287654e
clarify comments about MONO_METHOD_PARAMLIST
lambdageek Jul 15, 2021
6336699
[hot_reload] Store debug info of updated methods
lambdageek Jul 16, 2021
cdfb9a7
[hot_reload] Allocate modifiable tables in DeltaInfo
lambdageek Nov 12, 2021
4b250b9
[mini] Allow MONO_VERBOSE_METHOD='*:*'
lambdageek Nov 12, 2021
cdcf003
populate mutated table rows
lambdageek Nov 12, 2021
ac0ac83
[hot_reload] Switch lookups to the mutant tables
lambdageek Nov 16, 2021
25253f7
cleanup: remove of effective_table calculation
lambdageek Nov 19, 2021
38b17da
cleanup: Remove relative_delta_index from component API
lambdageek Nov 19, 2021
d1c1c8e
cleanup: Pass DeltaInfo to relative_delta_index
lambdageek Nov 19, 2021
629075d
cleanup: Store a list of DeltaInfo in the BaselineInfo
lambdageek Nov 19, 2021
3114871
Turn off method addition support, for now
lambdageek Nov 19, 2021
6e56f85
Fix null ptr when checking for updated ppdb info
lambdageek Nov 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixme in loader
  • Loading branch information
@lambdageek
lambdageek committed Nov 10, 2021
commit 0c4aa7460b6d404d793d9e7e4aefc3ac0565e6c1
4 changes: 4 additions & 0 deletions src/mono/mono/metadata/loader.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,6 +427,8 @@ find_method_in_class (MonoClass *klass, const char *name, const char *qname, con
{
int i;

/* FIXME: method refs from metadata-upate probably end up here */

/* Search directly in the metadata to avoid calling setup_methods () */
error_init (error);

Expand Down Expand Up @@ -1160,6 +1162,8 @@ mono_get_method_checked (MonoImage *image, guint32 token, MonoClass *klass, Mono
MonoMethod *result = NULL;
gboolean used_context = FALSE;

/* FIXME: method definition lookups for metadata-update probably end up here */

/* We do everything inside the lock to prevent creation races */

error_init (error);
Expand Down