Update DI external tests for Stashbox #61928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
community-contribution
|
Tagging subscribers to this area: @eerhardt, @maryamariyan Issue DetailsHey, Related to #53919, I've added support for the Thanks!
|
|
|
eerhardt
approved these changes
Nov 30, 2021
Member
eerhardt
left a comment
eerhardt
left a comment
There was a problem hiding this comment.
LGTM. Waiting for CI to go green and then I'll merge.
Member
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
Related to #53919, I've added support for the
IServiceProviderIsServiceinterface to Stashbox's MS DI integration and updated the external DI test project, to allow the execution of the related tests.Thanks!