Skip to content

[wasm] Misc CI/test run improvements #61937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
radical merged 11 commits into from
Nov 24, 2021
Merged

[wasm] Misc CI/test run improvements #61937

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
54f9ff9
[wasm] Update chrome used for testing to latest stable
radical Nov 22, 2021
26c0b6d
[wasm] Disable WBT tests failing on windows
radical Nov 21, 2021
e97a271
[wasm][aot] Don't try to run the tests, if AOT build fails
radical Nov 22, 2021
dd0a328
[wasm] Disable AOT builds on windows
radical Nov 22, 2021
e580ee4
[wasm] Disable JS Interop failing tests
radical Nov 22, 2021
80cf2c9
[wasm] Enable windows tests on manual runs
radical Nov 22, 2021
61c135d
[wasm] honor RunSmokeTestsOnly
radical Nov 23, 2021
23e77cb
Update src/libraries/sendtohelixhelp.proj
radical Nov 23, 2021
bd44d3d
[wasm][win] fix wasm/windows networking test failures
radical Nov 23, 2021
8bb6952
Merge remote-tracking branch 'origin/main' into misc-wasm-fixes
radical Nov 23, 2021
f3a7b51
Add condition to ensure that the middleware exists
radical Nov 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[wasm][win] fix wasm/windows networking test failures 
`System.Net.WebSockets.Client.Tests`, and
`System.Net.Http.Functional.Tests` fail because the echo servers don't
get included in the helix payload.

 - Don't condition the inclusion on `RunSmokeTestsOnly`, instead it will
   be included only if it was built, and that would depend correctly on
   `RunSmokeTestsOnly`.
- Pass the smoke test argument to the build command line for
  wasm/windows
  • Loading branch information
@radical
radical committed Nov 23, 2021
commit bd44d3db23575a99e8cd0c9695ab8e4a006ff247
2 changes: 1 addition & 1 deletion eng/pipelines/runtime-staging.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,7 @@ jobs:
jobParameters:
testGroup: innerloop
nameSuffix: Windows_wasm
buildArgs: -subset mono+libs+host+packs+libs.tests -c $(_BuildConfig) /p:ArchiveTests=true /p:BrowserHost=windows
buildArgs: -subset mono+libs+host+packs+libs.tests -c $(_BuildConfig) /p:ArchiveTests=true /p:BrowserHost=windows $(_runSmokeTestsOnlyArg)
timeoutInMinutes: 180
condition: >-
or(
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/sendtohelixhelp.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,7 @@
<HelixCorrelationPayload Include="$(MonoTargetsTasksDir)" Destination="build/MonoTargetsTasks" />
</ItemGroup>

<ItemGroup Condition="'$(TargetOS)' == 'Browser' and '$(RunSmokeTestsOnly)' != 'true' and '$(Scenario)' != 'BuildWasmApps'">
<ItemGroup Condition="'$(TargetOS)' == 'Browser' and '$(Scenario)' != 'BuildWasmApps'">
<HelixCorrelationPayload Include="$(TestEchoMiddleware)" Destination="xharness/TestEchoMiddleware" />
<HelixCorrelationPayload Include="$(RemoteLoopMiddleware)" Destination="xharness/RemoteLoopMiddleware" />
</ItemGroup>
Expand Down