Skip to content

Disable changing align nop padding to breakpoints for arm64 under jit stress #61951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kunalspathak merged 3 commits into from
Nov 23, 2021
Merged

Disable changing align nop padding to breakpoints for arm64 under jit stress #61951

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be2ec77
Disable converting nop padding to breakpoints for arm64 under jit str…
AndyAyersMS Nov 23, 2021
ba9bb29
disable differently
AndyAyersMS Nov 23, 2021
96abd19
fix
AndyAyersMS Nov 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
disable differently
  • Loading branch information
@AndyAyersMS
AndyAyersMS committed Nov 23, 2021
commit ba9bb2947eb4abd5d782da2c39b9b45fee5304c8
20 changes: 10 additions & 10 deletions src/coreclr/jit/emitarm64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11459,16 +11459,16 @@ size_t emitter::emitOutputInstr(insGroup* ig, instrDesc* id, BYTE** dp)
// then add "bkpt" instruction.
// instrDescAlign* alignInstr = (instrDescAlign*)id;

// if (emitComp->compStressCompile(Compiler::STRESS_EMITTER, 50) &&
// (alignInstr->idaIG != alignInstr->idaLoopHeadPredIG) && !skipIns)
// {
// // There is no good way to squeeze in "bkpt" as well as display it
// // in the disassembly because there is no corresponding instrDesc for
// // it. As such, leave it as is, the "0xD43E0000" bytecode will be seen
// // next to the nop instruction in disasm.
// // e.g. D43E0000 align [4 bytes for IG07]
// ins = INS_bkpt;
// }
if (emitComp->compStressCompile(Compiler::STRESS_EMITTER, 50) &&
(alignInstr->idaIG != alignInstr->idaLoopHeadPredIG) && !skipIns)
{
// There is no good way to squeeze in "bkpt" as well as display it
// in the disassembly because there is no corresponding instrDesc for
// it. As such, leave it as is, the "0xD43E0000" bytecode will be seen
// next to the nop instruction in disasm.
// e.g. D43E0000 align [4 bytes for IG07]
// ins = INS_bkpt;
}
#endif
}
#endif // FEATURE_LOOP_ALIGN
Expand Down