Skip to content

Reduce allocations in code generated by Logging generators (#61162) #62011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maryamariyan merged 5 commits into from
Jan 19, 2022
Merged

Reduce allocations in code generated by Logging generators (#61162) #62011

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
859cf5b
Reduce allocations in code generated by Logging generators (#61162)
shadow-cs Nov 3, 2021
fd5ce9d
Add summary and EditorBrowsableState.Never to generated types
shadow-cs Jan 11, 2022
2560223
Add an .editorconfig to properly handle ending EOL for baselines
shadow-cs Jan 11, 2022
b857537
Update wording of summary for generated classes
shadow-cs Jan 14, 2022
a556d85
Fix baselines
shadow-cs Jan 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update wording of summary for generated classes 
Co-authored-by: Eric Erhardt <[email protected]>
  • Loading branch information
@shadow-cs @eerhardt
shadow-cs and eerhardt authored Jan 14, 2022
commit b85753796411100be06da9dd88dba680e9671d0f
4 changes: 2 additions & 2 deletions ...libraries/Microsoft.Extensions.Logging.Abstractions/gen/LoggerMessageGenerator.Emitter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ internal class Emitter

private static readonly string s_generatedTypeSummary =
"<summary> " +
"The implementation of this type is subject to change without further notice, " +
"do not use it directly in your code. " +
"This API supports the logging infrastructure and is not intended to be used directly from your code. " +
"It is subject to change in the future. " +
"</summary>";
private static readonly string s_generatedCodeAttribute =
$"global::System.CodeDom.Compiler.GeneratedCodeAttribute(" +
Expand Down