Skip to content

Add parser tests from nim-regex #62093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danmoseley merged 8 commits into from
Dec 3, 2021
Merged

Add parser tests from nim-regex #62093

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8e0cdeb
new parser tests
danmoseley Nov 27, 2021
87ca318
baseline
danmoseley Nov 27, 2021
9baa06c
Nim tests
danmoseley Nov 27, 2021
424ae3b
typos
danmoseley Nov 27, 2021
e9844c8
positive cases
danmoseley Nov 27, 2021
5a9dc84
new parser tests
danmoseley Nov 27, 2021
8e143ac
change to \u
danmoseley Nov 27, 2021
64e3d85
Address feedback
danmoseley Nov 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
change to \u
  • Loading branch information
@danmoseley
danmoseley committed Nov 27, 2021
commit 8e143ac4f87a2055b21f7f479a3fd7ce695bc580
6 changes: 3 additions & 3 deletions src/libraries/System.Text.RegularExpressions/tests/RegexParserTests.netcoreapp.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,9 +231,9 @@ public partial class RegexParserTests
[InlineData(@"abc(?q)", RegexOptions.None, RegexParseError.InvalidGroupingConstruct, 6)]
[InlineData(@"abc[]", RegexOptions.None, RegexParseError.UnterminatedBracket, 5)]
[InlineData(@"abc\A{10}", RegexOptions.None, null)] // Nim error: "Invalid repetition range, either char, shorthand (i.e: \\w), group, or set expected before repetition range"
[InlineData(@"弢(?Pabc", RegexOptions.None, RegexParseError.InvalidGroupingConstruct, 5)]
[InlineData(@"弢aaa(?Pabc", RegexOptions.None, RegexParseError.InvalidGroupingConstruct, 8)]
[InlineData(@"弢弢弢(?Pabc", RegexOptions.None, RegexParseError.InvalidGroupingConstruct, 9)]
[InlineData(@"\uD87E\uDC94(?Pabc", RegexOptions.None, RegexParseError.InvalidGroupingConstruct, 5)]
[InlineData(@"\uD87E\uDC94aaa(?Pabc", RegexOptions.None, RegexParseError.InvalidGroupingConstruct, 8)]
[InlineData(@"\uD87E\uDC94\uD87E\uDC94\uD87E\uDC94(?Pabc", RegexOptions.None, RegexParseError.InvalidGroupingConstruct, 9)]
// End of Nim parser tests ==============

[SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework)]
Expand Down