Skip to content

No-op ConcurrentStack.PushRange(T[]) if empty #62126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eiriktsarpalis merged 4 commits into from
Nov 30, 2021
Merged

No-op ConcurrentStack.PushRange(T[]) if empty #62126

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d8e1bfb
No-op ConcurrentStack.PushRange(T[]) if empty
martincostello Nov 29, 2021
f4e8a88
Add more bounds checks
martincostello Nov 29, 2021
b7729b4
Review feedback
martincostello Nov 29, 2021
069a9eb
Add extra test case
martincostello Nov 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add more bounds checks 
Assert that ArgumentOutOfRangeException is thrown if specifying indexes for an empty array with PushRange(T[], int, int).
  • Loading branch information
@martincostello
martincostello committed Nov 29, 2021
commit f4e8a88b30ca5c6049b64fccff79ba720a3f49ff
2 changes: 2 additions & 0 deletions src/libraries/System.Collections.Concurrent/tests/ConcurrentStackTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,8 @@ public void PushRange_InvalidArguments_Throws()
var stack = new ConcurrentStack<int>();
Assert.Throws<ArgumentNullException>(() => stack.PushRange(null));
Assert.Throws<ArgumentNullException>(() => stack.PushRange(null, 0, 0));
Assert.Throws<ArgumentOutOfRangeException>(() => stack.PushRange(new int[0], 0, 0));
Assert.Throws<ArgumentOutOfRangeException>(() => stack.PushRange(new int[0], 0, 1));
Assert.Throws<ArgumentOutOfRangeException>(() => stack.PushRange(new int[1], 0, -1));
Assert.Throws<ArgumentOutOfRangeException>(() => stack.PushRange(new int[1], -1, 1));
Assert.Throws<ArgumentOutOfRangeException>(() => stack.PushRange(new int[1], 2, 1));
Expand Down