Skip to content

Fix use of StringBuilder.AppendFormat in ILCompiler #62147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stephentoub merged 1 commit into from
Dec 1, 2021
Merged

Fix use of StringBuilder.AppendFormat in ILCompiler #62147

stephentoub merged 1 commit into from
Dec 1, 2021

Conversation

@stephentoub
Copy link
Member

@stephentoub stephentoub commented Nov 29, 2021

Fixes #62137

@ghost ghost added the area-R2RDump-coreclr Ready-to-run image dump tool label Nov 29, 2021
@danmoseley
Copy link
Member

danmoseley commented Nov 30, 2021

Oddly enough, failure in the NonBacktracking regex tests.

@stephentoub stephentoub merged commit 985f477 into dotnet:main Dec 1, 2021
@stephentoub stephentoub deleted the fixaf branch December 1, 2021 15:34
@joshpeterson joshpeterson mentioned this pull request Dec 1, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotas jkotas jkotas approved these changes

Assignees

No one assigned

Labels

area-R2RDump-coreclr Ready-to-run image dump tool

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Is 'sb.AppendFormat($"{Signature.ParameterTypes[i]}");' a typo error

3 participants

@stephentoub @danmoseley @jkotas